Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODSG-45] D10 upgrade #235

Merged
merged 16 commits into from
Aug 30, 2023
Merged

[ODSG-45] D10 upgrade #235

merged 16 commits into from
Aug 30, 2023

Conversation

orakili
Copy link
Contributor

@orakili orakili commented Aug 27, 2023

Refs: ODSG-45

This upgrades the ODSG site to Drupal 10 and PHP 8.2.

Tests

Test the update the site to D10

  1. Create/update local site to latest DB from prod
    1. Check out the develop branch
    2. Optionally create a new instance with ./local/install.sh -m -c -i)
    3. Install the dev dependencies with ./local/exec.sh -w /srv/www site composer install
    4. Import a recent DB dump
    5. Clear the cache
    6. Import the config with ./local/exec.sh -u appuser site drush cim
  2. Check out the feature/ODSG-45 branch
  3. Recreate the with the PHP 8.2 image with ./local/install.sh -m
  4. Install the dev dependencies with ./local/exec.sh -w /srv/www site composer install
  5. Update the site to D10 with ./local/exec.sh -u appuser site drush deploy
  6. Follow the post deployment steps from [UNO-777] Change OCHA feeds to use RW API. #227

Test the updated site

This should be done in parallel on the prod site and on the local site or the dev site.

Note: the local and dev sites have the fixed publications blocks from #227 while that hasn't yet been deployed to prod.

  1. Page access --> confirm same behavior as prod.
    1. As anonymous user, check access to several pages and files and confirm the redirection to the welcome page
    2. Do the same as an authorized users without any role
    3. Do the same as an ODSG member (access to public pages)
    4. Do the same as a content manager (access to public and private pages + access to unpublished content)
  2. Appearance --> visit several pages and confirm similarity with prod with a few slight differences like the heading margins due to the update to the latest CD theme, that's normal
  3. Edit some pages, make some changes and confirm they are reflected when saving the pages

@orakili orakili mentioned this pull request Aug 27, 2023
@github-actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.9 (cli) (built: Aug 16 2023 19:49:37) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.9, Copyright (c) Zend Technologies with Zend OPcache v8.2.9, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.5.8 2023-06-09 17:13:21
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't finished testing yet as I'm getting infinite redirects when I try to log in. Will come back to this tomorrow...

docker/Dockerfile Show resolved Hide resolved
composer.json Show resolved Hide resolved
@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 0% ( 0 / 42 )
Lines: 0% ( 0 / 42 )

@orakili
Copy link
Contributor Author

orakili commented Aug 29, 2023

Haven't finished testing yet as I'm getting infinite redirects when I try to log in. Will come back to this tomorrow...

@lazysoundsystem Could you take detailed notes (and screenshots?) of the steps and what happens to see if that's something that can be reproduced locally or on dev?

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what changed, but I went through the steps again and no longer found the redirects on login.

All looks good.

@orakili orakili merged commit f9c69ab into develop Aug 30, 2023
@lazysoundsystem lazysoundsystem deleted the feature/ODSG-45 branch August 30, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants