Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workspace setting to not read flat config eslint file #482

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add workspace setting to not read flat config eslint file #482

merged 1 commit into from
Dec 19, 2024

Conversation

Onitoxan
Copy link
Contributor

@Onitoxan Onitoxan commented Dec 19, 2024 •
edited
Loading

Description

Temporal Temporary solution for eslint-vscode to work as expected as long as we are in eslint v8.54.0. Without this setting, hpc_service eslint.config.js interferes with eslintrc.json config file of hpc-cdm

TODO:

Upgrade eslint to latest v9 minor version available and remove this newly added setting

@Onitoxan Onitoxan added the ready for review All comments have been addressed, and the Pull Request is ready for review label Dec 19, 2024
@Onitoxan Onitoxan requested a review from a team as a code owner December 19, 2024 11:53
unocha-hpc
unocha-hpc approved these changes Dec 19, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Pl217
Pl217 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Pl217 Pl217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporal ≠ Temporary :P

@Onitoxan
Copy link
Contributor Author

Temporal ≠ Temporary :P

A temporal solution indeed would be a crazy thing to be adding in a PR :)

@Onitoxan Onitoxan merged commit 25d01ab into develop Dec 19, 2024
3 checks passed
@Onitoxan Onitoxan deleted the eslint-vscode-fix branch December 19, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unocha-hpc unocha-hpc unocha-hpc approved these changes

@Pl217 Pl217 Pl217 approved these changes

Assignees

@Pl217 Pl217

Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Onitoxan @Pl217 @unocha-hpc