-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] - HPC-9658 Add cypress tests #479
Open
Onitoxan
wants to merge
8
commits into
HPC-8546
Choose a base branch
from
HPC-9658
base: HPC-8546
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onitoxan
added
the
ready for review
All comments have been addressed, and the Pull Request is ready for review
label
Nov 27, 2024
unocha-hpc
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks have passed and this pull request is ready for manual review
Onitoxan
force-pushed
the
HPC-8546
branch
3 times, most recently
from
December 4, 2024 10:39
7597db7
to
5eef990
Compare
Onitoxan
force-pushed
the
HPC-8546
branch
2 times, most recently
from
December 19, 2024 12:03
2246d70
to
a21eed7
Compare
There was no prior tests written in the monorepo, so it won't cause problems to upgrade many major versions.
unocha-hpc
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks have passed and this pull request is ready for manual review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nature of PR
Description
Initial implementation of tests for FTS Admin. These test consist of mocked data and mocked endpoints, so we are focusing and isolating frontend behaviors. This is a decision in order to have deterministic tests. Therefore these tests would not really be E2E tests.
How to test changes
For testing, you can run the test in headed mode by running :
All the test that are written should not fail.
TODO:
These test can be really improved and implement way more use cases, but I think as a first approach is best to review these small tests and decide if we want to invest more time into building them