Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HID-2413] CD v9.4.0 #433

Merged
merged 15 commits into from
Apr 24, 2024
Merged

[HID-2413] CD v9.4.0 #433

merged 15 commits into from
Apr 24, 2024

Conversation

rupl
Copy link
Contributor

@rupl rupl commented Apr 11, 2024 •
edited
Loading

HID-2413

Upgrades to CD v9.4.0. Notable adjustments:

  • OCHA Services markup is updated, and no longer gets moved into the Global Header via JS. It appears in the footer.
  • CD Dropdown is updated with a11y and UX improvements.
  • CD Alert is updated with many a11y improvements.
  • Landmark roles now have labels instead of duplicate role attributes.

Additional adjustments that were HID-specific:

  • Did NOT apply the preload markup for fonts as the inline JS required the CSP to be adjusted in such a way as to render it toothless for JS.
  • Removed IE11 polyfills

rupl added 15 commits April 9, 2024 15:02
@rupl
fix(style): load fonts async
2973449 
Refs: HID-2413, CD-514
@rupl
chore(deps-dev): update CSS pipeline to handle native nesting
df928f6 
CD uses native nesting now, so the pipeline must
stay current.

Refs: HID-2413
@rupl
chore(deps): update CD CSS to v9.4.0
839818f 
Refs: HID-2413
@rupl
fix(style): compile CSS
b1961ac 
Refs: HID-2413
@rupl
fix(style): update OCHA Services to be in footer
4470492 
Refs: HID-2413
@rupl
fix(a11y): update landmark roles with labels
4a492d1 
Refs: HID-2413
@rupl
fix: markup for async fonts
cc38428 
The async font strategy used by CD require the CSP
to be weakened to the point of uselessness. Reverting.

Refs: 2973449
@rupl
fix: update JS for HID
eac1738 
Removed IE11 polyfills and updated JS with
CD Dropdown v9.4.0

Refs: HID-2413
@rupl
fix: update copyright
0424d34 
Refs: HID-2413
@rupl
fix(style): update SVG sprite
ba6bf38 
Refs: HID-2413
@rupl
fix(security): new GTM hash for CSP
aeb1e07 
Refs: HID-2413
@rupl
fix(style): update CD Alert markup
ba43e82 
Refs: HID-2413
@rupl
fix(style): update OCHA logos
acb00c3 
Refs: HID-2413
@rupl
fix(a11y): replace redundant role with aria-label on main tags
297acc7 
Refs: HID-2413
@rupl
style: add comment about non-preload font markup
b8cfd92 
Refs: HID-2413
@rupl rupl requested a review from orakili April 11, 2024 11:50
@rupl
Copy link
Contributor Author

rupl commented Apr 24, 2024

Imma yolo this onto dev and see how it turns out.

@rupl rupl merged commit 4fdb602 into dev Apr 24, 2024
2 checks passed
orakili
orakili reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. I tested the upgrade and everything looks fine. Thanks.

@rupl
Copy link
Contributor Author

rupl commented Apr 26, 2024

Thanks!

@rupl rupl deleted the HID-2413 branch April 26, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orakili orakili orakili left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rupl @orakili