Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CD-483] SDC for site #369

Merged
merged 4 commits into from
Jan 5, 2024
Merged

[CD-483] SDC for site #369

merged 4 commits into from
Jan 5, 2024

Conversation

rupl
Copy link
Contributor

@rupl rupl commented Jan 3, 2024

Companion to UN-OCHA/common_design#451 — read all about it over there.

Note: this is technically blocked until the CD has a release containing the above PR. Marking as such.

@rupl rupl added the blocked label Jan 3, 2024
@rupl rupl requested a review from left23 January 3, 2024 10:00
@rupl rupl mentioned this pull request Jan 3, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.14 (cli) (built: Dec 21 2023 20:19:50) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.14, Copyright (c) Zend Technologies with Zend OPcache v8.2.14, Copyright (c), by Zend Technologies with Xdebug v3.3.0, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.6 2023-12-08 18:32:26
Drupal Logs

Pusher: @rupl, Action: pull_request, Workflow: Run tests

left23
left23 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@left23 left23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with CD branch. Works as described!

@rupl
chore(deps): bump common_design to 9.3.0
74df3d4 
Refs: CD-483
@rupl
Merge remote-tracking branch 'origin/develop' into CD-483-sdc-site
9a57d18 
* origin/develop:
  chore: Update all outdated drupal/* packages.
  chore: unblock updates
  chore: Update all outdated drupal/* packages.
@rupl rupl merged commit c307d71 into develop Jan 5, 2024
1 check passed
@rupl rupl deleted the CD-483-sdc-site branch January 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@left23 left23 left23 approved these changes

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rupl @left23