Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates: allow composer update with drupal-lenient #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lazysoundsystem
Copy link

Refs: OPS-11381

Tested with Starterkit and ODSG - I think we could just test for Drupal sites instead of adding a flag, but this gives more control.

The 'clumsy' in the commit message is because I thought I'd be able to put a conditional around just the command itself, not the whole step.

Refs: OPS-11381
I think I looked before to see if there's a better way to have an
optional argument, instead of repeating the whole step, but if there is
I haven't yet found it.
@lazysoundsystem lazysoundsystem requested a review from cafuego March 6, 2025 19:07
Copy link

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work. Maybe we can use a step that generates an output that contains the actual --no-scripts or `` depending on the input boolean, then re-use that output instead of duplicating the steps. that can be a later refactor tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants