Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix variable #39

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Feature/fix variable #39

merged 6 commits into from
Jan 21, 2025

Conversation

ellendejong
Copy link
Contributor

@ellendejong ellendejong commented Jan 17, 2024 •
edited
Loading

What has changed?

  • Renamed log_file_writer: file ain't a log.
  • Split line date and run_folder.
  • flake8

@ellendejong ellendejong marked this pull request as ready for review February 20, 2024 13:47
@ellendejong ellendejong mentioned this pull request Dec 30, 2024
Open
Jorisvansteenbrugge
Jorisvansteenbrugge approved these changes Jan 14, 2025
View reviewed changes
Copy link

@Jorisvansteenbrugge Jorisvansteenbrugge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small textual and formatting changes, LGTM

@ellendejong ellendejong merged commit 47070df into development Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorisvansteenbrugge Jorisvansteenbrugge Jorisvansteenbrugge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellendejong @Jorisvansteenbrugge