fix(serverless-hub) retry logic bug #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daywiss
reviewed
Oct 27, 2020
| @@ -60,7 +60,9 @@ hub.post("/", async (req, res) => { | |||
| // Fetch the last block number this given config file queried the blockchain at if running in production. Else, pull from env. | |||
| const lastQueriedBlockNumber = await _getLastQueriedBlockNumber(req.body.configFile); | |||
| if (!configObject || !lastQueriedBlockNumber) | |||
| throw new Error("Serverless hub requires a config object and a last updated block number!"); | |||
| throw new Error( | |||
| `Serverless hub requires a config object and a last updated block number! configObject:${configObject} lastQueriedBlockNumber:${lastQueriedBlockNumber}` | |||
There was a problem hiding this comment.
Does configObject need to be stringified?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2111 yesterday introduced a small bug in the hub wherein by not returning the nested value within the retry logic. The PR has been tested in production with a hot-fix docker container and has been validated to work as expected.
Summary
Adds a
returnto the value retrieved from GCP data store. This PR also expands the error message a bit by showing the underlyingconfigObject&lastQueriedBlockNumberreturned by the function.