Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock web3 version to fix voter dapp #1764

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Conversation

mrice32
Copy link
Member

@mrice32 mrice32 commented Jul 20, 2020

web3 upgraded to a newer version of the Ethers abi coder/decoder. This caused calls in the dapp where we pass around large salts to fail to pass abi verification.

This fixes that issue by temporarily locking down the version of web3 to 1.2.7. This also required locking the version of web3 in the @umaprotocol/store drizzle package fork as well.

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this fix worked! Its probably worth referencing this outstanding issue about web3 1.2.28 so that it links back to that issue and to remind us why we locked at this version:

web3/web3.js#3544

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.73% when pulling 6f98098 on mrice32:fix_dapp into 4abe2d9 on UMAprotocol:master.

@mrice32
Copy link
Member Author

mrice32 commented Jul 20, 2020

Glad this fix worked! Its probably worth referencing this outstanding issue about web3 1.2.28 so that it links back to that issue and to remind us why we locked at this version:

ethereum/web3.js#3544

Ahhh, yes, thanks. I meant to put this in the description. +1

@mrice32 mrice32 merged commit 65fe5ea into UMAprotocol:master Jul 20, 2020
@mrice32 mrice32 deleted the fix_dapp branch July 20, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants