[model cards] Improve the widget example selection: not based on embeddings, better for QA
#2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
Details
Previously, the widget selection didn't consider asymmetric models (e.g. QA), so it would compare questions against questions - not very useful. I've updated it for improved selection for QA. Also, samples are now picked more at random: no more embedding when saving a model. This speeds up the saving process. Also,
generate_widget_examplesis now deprecated as a result, as widget examples are now always generated (but only once).See e.g. https://huggingface.co/tomaarsen/mpnet-base-gooaq with the new widget examples.