Fix semantic_search_usearch() for single query #2572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where the
sentence_transformers.quantization.semantic_search_usearch()
method would fail withTypeError: 'numpy.float32' object is not iterable
where only a single query is used.Example code:
This raises
TypeError: 'numpy.float32' object is not iterable
without this patch, because the code expects thescores
andindices
to be a 2D array:sentence-transformers/sentence_transformers/quantization.py
Lines 300 to 309 in 0253363
However, the
usearch
implementation in the Python client returns 1D arrays for a single query, and a 2D array for multiple queries:The problem also manifests in the example code here:
sentence-transformers/examples/applications/embedding-quantization/semantic_search_usearch.py
Lines 16 to 19 in 0253363
When just a single query is passed, it fails with the error above.
I wasn't sure if I should add tests for this patch — I can definitely do so, when needed.