Ensure that self.model_card_data.model_id is set

UKPLab · Jun 4, 2024 · 0dbd349 · 0dbd349
1 parent 0f84a7b
commit 0dbd349
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/sentence_transformers/SentenceTransformer.py b/sentence_transformers/SentenceTransformer.py
@@ -1095,11 +1095,12 @@ def _create_model_card(
         # we don't generate a new model card, but reuse the old one instead.
         if self._model_card_text and self.model_card_data.trainer is None:
             model_card = self._model_card_text
-            # If the original model card was saved without a model_id, we replace the model_id with the new model_id
-            model_card = model_card.replace(
-                'model = SentenceTransformer("sentence_transformers_model_id"',
-                f'model = SentenceTransformer("{self.model_card_data.model_id}"',
-            )
+            if self.model_card_data.model_id:
+                # If the original model card was saved without a model_id, we replace the model_id with the new model_id
+                model_card = model_card.replace(
+                    'model = SentenceTransformer("sentence_transformers_model_id"',
+                    f'model = SentenceTransformer("{self.model_card_data.model_id}"',
+                )
         else:
             try:
                 model_card = generate_model_card(self)