Add Zip64 Support to JS Zip Reader #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As eval files get larger (approaching 4GB), the central directory will stop using 32 bit ints and instead use 64 bit ints to store offsets to byte ranges. This is signaled by the file offset being a sentinel value, in which case we need to look through the extra fields to find the 64 bit offset and use that instead. This change adds support for reading these large zip files.
jjallaire-aisi
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As eval files get larger (approaching 4GB), the central directory will stop using 32 bit ints and instead use 64 bit ints to store offsets to byte ranges.
This is signaled by the file offset being a sentinel value, in which case we need to look through the extra fields to find the 64 bit offset and use that instead.
This change adds support for reading these large zip files.
This PR contains:
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: