-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMS-3977): broker details - form validation updates #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3278) * chore(EMS-3966): update dependabot to run during non working hours * chore(EMS-3966): update dependabot to run weekly * chore(EMS-3966): update dependabot to run weekly * chore(EMS-3966): update dependabot to run monthly
fix(EMS-3988): quote tool - type of policy - hint text
|
Merging this with some failing tests (unrelated to this PR), to help clear the PR backlog. Other PRs have fixes. |
dbdda68
into
main-broker-address-lookup
174 of 183 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the form validation in the "Broker details" form to include validation rules for the following fields:
Note: E2E test coverage for postcode field will be improved in a separate ticket PR.
Resolution ✔️
completeBrokerDetailsForm
cypress command.MAXIMUM_CHARACTERS
constants.BROKER_DETAILS
validation E2E test.BROKER_DETAILS
validation rules.Miscellaneous ➕
postCode
topostcode
.