Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMS-3977): broker details - form validation updates #3312

Merged
merged 20 commits into from
Nov 28, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Nov 15, 2024

Introduction ✏️

This PR updates the form validation in the "Broker details" form to include validation rules for the following fields:

  • Based in the UK
  • Postcode
  • Building number/name

Note: E2E test coverage for postcode field will be improved in a separate ticket PR.

Resolution ✔️

  • Update completeBrokerDetailsForm cypress command.
  • Update MAXIMUM_CHARACTERS constants.
  • Update error messages content strings.
  • Update E2E application fixtures.
  • Update BROKER_DETAILS validation E2E test.
  • Update API schema, SQL dump.
  • Create new UI BROKER_DETAILS validation rules.
  • Update nunjucks template to consume submitted values.

Miscellaneous ➕

  • Rename instances of postCode to postcode.

@ttbarnes ttbarnes self-assigned this Nov 15, 2024
@ttbarnes ttbarnes added enhancement New feature or request feature New functionality chore Chore labels Nov 15, 2024
@ttbarnes ttbarnes changed the title feat(EMS-3977): broker details - form validation feat(EMS-3977): broker details - form validation updates Nov 15, 2024
Base automatically changed from feat/EMS-3972 to main-broker-address-lookup November 22, 2024 11:16
@ttbarnes
Copy link
Contributor Author

Merging this with some failing tests (unrelated to this PR), to help clear the PR backlog. Other PRs have fixes.

@ttbarnes ttbarnes merged commit dbdda68 into main-broker-address-lookup Nov 28, 2024
174 of 183 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-3977 branch November 28, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore enhancement New feature or request feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants