Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMS-3972): broker details - based in the uk form fields #3295

Merged
merged 14 commits into from
Nov 22, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Nov 8, 2024

Introduction ✏️

As part of "Broker - address lookup" functionality, the "Policy - Broker details" form needs updating so that:

  • There is no "full address" field.
  • There is an "Broker based in the UK" question with conditional fields.

Note: this PR also merges main intro main-broker-address-lookup.

Resolution ✔️

  • Add new DB fields to the broker table: buildingNumberOrName, isBasedInUk
  • Remove the FULL_ADDRESS field, disable certain things to be moved in a future PR.
  • Update relevant cypress commands.
  • Update field IDs, field content strings.
  • Update E2E test.
  • Update "Broker details" controllers pageVariables, add HTML_FLAGS
  • Update the broker'smapSubmittedData function to conditionally nullify IS_BASED_IN_UK related fields.
  • Update nunjucks template.

…3278)

* chore(EMS-3966): update dependabot to run during non working hours

* chore(EMS-3966): update dependabot to run weekly

* chore(EMS-3966): update dependabot to run weekly

* chore(EMS-3966): update dependabot to run monthly
@ttbarnes ttbarnes added enhancement New feature or request feature New functionality chore Chore labels Nov 8, 2024
@ttbarnes ttbarnes self-assigned this Nov 8, 2024
Copy link
Collaborator

@abhi-markan abhi-markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke to @ttbarnes commented code will not be merged to main therefore approving.

@ttbarnes ttbarnes merged commit ecad36f into main-broker-address-lookup Nov 22, 2024
177 of 182 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-3972 branch November 22, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore enhancement New feature or request feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants