chore(EMS-1964): Merge main into main-application-no-pdf, update no PDF form attributes
#1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…nds (#1481) * chore(tests): rename/align assertSummaryListRowValue cypress command name * chore(tests): fix/update flaky date tests
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat(EMS-2386): analytics - google tag manager * chore(docs): add documentation to e2e analytics functions * chore(docs): add documentation to e2e analytics functions * chore(tests): update analytics e2e test description * feat(EMS-2386): added SHA512 for Google scripts * docs(EMS-2386): sri hash generation documentation --------- Co-authored-by: Abhi Markan <abhi.markan@ukexportfinance.gov.uk>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tead of date-fns (#1463) * chore(EMS-2394): replace date-fns date construction with native js * chore(EMS-2394): replace date-fns date construction with native js * chore(tech): revert extra spacing * chore(EMS-2394): fix/update e2e test * chore(EMS-2394): fix/update e2e test
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Abhi Markan <abhi.markan@ukexportfinance.gov.uk>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#1511) * chore(EMS-1964): move external ui currency api calls into the exip api * chore(EMS-1964): fix/update unit test * chore(EMS-1964): update mapCurrencies function to use a new 'name' field id
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore(EMS-2414): add enctype to all forms * chore(EMS-2414): update core page checks to check for form attributes * chore(EMS-2414): fix/update e2e tests
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Zainzzkk
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the "no pdf" branch to have the latest code from
main.Since
mainhas had changes and additions to all form elements, those changes have been made to some new forms created in the "no pdf" branch.Resolution ✔️
mainintomain-application-no-pdfenctypeattribute with a value ofapplication/x-www-form-urlencoded.