Skip to content

Commit

Permalink
fix(deployment): deployment script
Browse files Browse the repository at this point in the history
  • Loading branch information
Abhi Markan committed Nov 10, 2023
1 parent e6f93e8 commit c644c5e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 12 deletions.
1 change: 0 additions & 1 deletion .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@
"UNSUPPORTRED",
"alphanum",
"hrefs",
"occured",
"sqldb"
],
"dictionaries": [
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Each stage in the workflow is associated with one or more jobs that contain spec

- **Security 🔑**: Security measures are implemented in this job.

- **Web App 🔧**: This job configures web applications and related services.
- **Web App 🔧**: This job configures web applications environment variables, application settings, database connection and other CI/CD configurations.

- **Logs and Diagnostic Settings 📒**: Configure logging and diagnostic settings for monitoring and troubleshooting.

Expand All @@ -115,7 +115,7 @@ To run this infrastructure automation workflow, follow these steps:

### Conclusion 🎉

The EXIP Infrastructure Automation workflow streamlines the process of setting up infrastructure components, enhancing security, and configuring web applications. With the automation in place, you can maintain consistent environments for development, staging, and production, and deploy with confidence.
The EXIP Infrastructure Automation workflow streamlines the process of setting up infrastructure components, enhancing security, configuring web applications and database With the automation in place, you can maintain consistent environments for development, staging, and production, and deploy with confidence.

If you have any questions or need further assistance, please don't hesitate to reach out to the development team. Happy automating! 🤖✨

Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@
# https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-naming
#
#
# Following Azure services are consumed:
# 1. Azure resource group - https://learn.microsoft.com/en-us/cli/azure/group?view=azure-cli-latest#az-group-create
# 2. Azure container registry - https://learn.microsoft.com/en-us/cli/azure/acr?view=azure-cli-latest#az-acr-create
# 3. Azure WebApp - https://learn.microsoft.com/en-us/azure/app-service/overview
#
#
# Execution
# *********
# GHA is only invoked when following conditions are satisfied:
Expand Down Expand Up @@ -58,7 +52,7 @@ jobs:
name: Database 💾
needs: setup
environment: ${{ needs.setup.outputs.environment }}
if: contains('["1"]', vars.DATABASE)
if: ${{ '1' == vars.DATABASE }}
env:
ENVIRONMENT: ${{ needs.setup.outputs.environment }}
runs-on: [self-hosted, EXIP, deployment]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/infrastructure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ jobs:
- name: Variables ✨
run: |
echo "API_URL=$(az webapp show --name app-${{ env.PRODUCT }}-api-${{ env.TARGET }}-${{ vars.VERSION }} --query defaultHostName -o tsv)" >> $GITHUB_ENV
echo "MYSQL_URL=$(az network private-dns zone list --query ['?contains(name, `sql`)'].name -o tsv)" >> $GITHUB_ENV
echo "MYSQL_URL=$(az mysql flexible-server list --query [].fullyQualifiedDomainName -o tsv)" >> $GITHUB_ENV
- name: Setting 🧱
uses: Azure/cli@v1.0.8
Expand Down Expand Up @@ -623,7 +623,7 @@ jobs:
WEBSITES_PORT='${{ vars.API_PORT }}' \
TLS_CERTIFICATE='${{ secrets.TLS_CERTIFICATE }}' \
TLS_KEY='${{ secrets.TLS_KEY }}' \
DATABASE_URL='mysql://${{ secrets.MYSQL_USER }}:${{ secrets.MYSQL_PASSWORD }}@${{ env.MYSQL_URL }}/${{ env.PRODUCT }}' \
DATABASE_URL='mysql://${{ secrets.MYSQL_USER }}:${{ secrets.MYSQL_PASSWORD }}@${{ env.MYSQL_URL }}:${{ vars.DATABASE_PORT }}/${{ env.PRODUCT }}' \
API_KEY='${{ secrets.API_KEY }}' \
APIM_MDM_URL='${{ secrets.APIM_MDM_URL }}' \
APIM_MDM_KEY='${{ secrets.APIM_MDM_KEY }}' \
Expand Down

0 comments on commit c644c5e

Please sign in to comment.