fix(EMS-3385): no PDF - policy - nullify data when changing policy ty…

…pe (#2500) * fix(EMS-3385): no pdf - policy - nullify data when changing type of policy * fix(EMS-3385): no pdf - policy - nullify data when changing type of policy * fix(EMS-3385): no pdf - policy - nullify data when changing type of policy * fix(EMS-3385): add missing documentation * fix(EMS-3385): no pdf - policy - nullify data when changing type of policy * fix(EMS-3385): improve unit test * fix(EMS-3385): linting issues
UK-Export-Finance · Jun 4, 2024 · 55424cf · 55424cf
1 parent d7dd2b4
commit 55424cf
Show file tree

Hide file tree

Showing 34 changed files with 802 additions and 252 deletions.
diff --git a/e2e-tests/commands/insurance/assert-currency-form-fields.js b/e2e-tests/commands/insurance/assert-currency-form-fields.js
@@ -25,11 +25,7 @@ const {
  * @param {String} currency - Currency string
  * @return {Function} radio
  */
-const currencyRadio = ({
-  fieldId,
-  currency,
-  alternativeCurrencyFieldId = ALTERNATIVE_CURRENCY_CODE,
-}) => {
+const currencyRadio = ({ fieldId, currency, alternativeCurrencyFieldId = ALTERNATIVE_CURRENCY_CODE }) => {
   if (currency) {
     const { option } = radios(fieldId, currency);
     return option;

diff --git a/...ests/commands/insurance/change-policy-type-to-multiple-and-submit-contract-policy-form.js b/...ests/commands/insurance/change-policy-type-to-multiple-and-submit-contract-policy-form.js
@@ -8,7 +8,7 @@ const {
 
 /**
  * changePolicyTypeToMultipleAndSubmitContractPolicyForm
- * 1) Change policy type to multiple and submit the "contract policy" form.
+ * Change policy type to multiple and submit the "multiple contract policy" form.
  */
 const changePolicyTypeToMultipleAndSubmitContractPolicyForm = () => {
   summaryList.field(POLICY_TYPE).changeLink().click();

diff --git a/e2e-tests/commands/insurance/change-policy-type-to-single-and-submit-contract-policy-form.js b/e2e-tests/commands/insurance/change-policy-type-to-single-and-submit-contract-policy-form.js
@@ -0,0 +1,22 @@
+import { summaryList } from '../../pages/shared';
+import { typeOfPolicyPage } from '../../pages/insurance/policy';
+import { POLICY as FIELD_IDS } from '../../constants/field-ids/insurance/policy';
+
+const {
+  TYPE_OF_POLICY: { POLICY_TYPE },
+} = FIELD_IDS;
+
+/**
+ * changePolicyTypeToSingleAndSubmitContractPolicyForm
+ * Change policy type to single and submit the "single contract policy" form.
+ */
+const changePolicyTypeToSingleAndSubmitContractPolicyForm = () => {
+  summaryList.field(POLICY_TYPE).changeLink().click();
+
+  typeOfPolicyPage[POLICY_TYPE].single.label().click();
+  cy.clickSubmitButton();
+
+  cy.completeAndSubmitSingleContractPolicyForm({});
+};
+
+export default changePolicyTypeToSingleAndSubmitContractPolicyForm;
diff --git a/e2e-tests/commands/shared-commands/assertions/assert-currency-form-fields-are-empty.js b/e2e-tests/commands/shared-commands/assertions/assert-currency-form-fields-are-empty.js
@@ -0,0 +1,42 @@
+import { radios } from '../../../pages/shared';
+import { INSURANCE_FIELD_IDS } from '../../../constants/field-ids/insurance';
+import { checkAutocompleteInput } from '../../../shared-test-assertions/autocomplete-assertions';
+import {
+  EUR,
+  GBP,
+  JPY,
+  USD,
+} from '../../../fixtures/currencies';
+
+const {
+  CURRENCY: { CURRENCY_CODE, ALTERNATIVE_CURRENCY_CODE },
+} = INSURANCE_FIELD_IDS;
+
+/**
+ * assertCurrencyFormFieldsAreEmpty
+ * Assert that all "currency" form fields are empty:
+ * - 4x default options.
+ * - "alternative currency" option
+ * - "alternative currency" conditional autocomplete input.
+ */
+const assertCurrencyFormFieldsAreEmpty = () => {
+  const fieldId = CURRENCY_CODE;
+
+  const { option: option1 } = radios(fieldId, EUR.isoCode);
+  const { option: option2 } = radios(fieldId, GBP.isoCode);
+  const { option: option3 } = radios(fieldId, USD.isoCode);
+  const { option: option4 } = radios(fieldId, JPY.isoCode);
+  const { option: option5 } = radios(ALTERNATIVE_CURRENCY_CODE);
+
+  cy.assertRadioOptionIsNotChecked(option1.input());
+  cy.assertRadioOptionIsNotChecked(option2.input());
+  cy.assertRadioOptionIsNotChecked(option3.input());
+  cy.assertRadioOptionIsNotChecked(option4.input());
+  cy.assertRadioOptionIsNotChecked(option5.input());
+
+  cy.clickAlternativeCurrencyRadioOption();
+
+  checkAutocompleteInput.checkEmptyResults();
+};
+
+export default assertCurrencyFormFieldsAreEmpty;
diff --git a/...commands/shared-commands/assertions/assert-empty-contract-completion-date-field-values.js b/...commands/shared-commands/assertions/assert-empty-contract-completion-date-field-values.js
@@ -0,0 +1,20 @@
+import { field } from '../../../pages/shared';
+import FIELD_IDS from '../../../constants/field-ids/insurance/policy';
+
+const {
+  CONTRACT_POLICY: {
+    SINGLE: { CONTRACT_COMPLETION_DATE },
+  },
+} = FIELD_IDS;
+
+/**
+ * assertEmptyContractCompletionDateFieldValues
+ * Assert all CONTRACT_COMPLETION_DATE field values are empty.
+ */
+const assertEmptyContractCompletionDateFieldValues = () => {
+  field(CONTRACT_COMPLETION_DATE).dayInput().should('have.value', '');
+  field(CONTRACT_COMPLETION_DATE).monthInput().should('have.value', '');
+  field(CONTRACT_COMPLETION_DATE).yearInput().should('have.value', '');
+};
+
+export default assertEmptyContractCompletionDateFieldValues;
diff --git a/...sts/commands/shared-commands/assertions/assert-empty-requested-start-date-field-values.js b/...sts/commands/shared-commands/assertions/assert-empty-requested-start-date-field-values.js
@@ -0,0 +1,18 @@
+import { field } from '../../../pages/shared';
+import FIELD_IDS from '../../../constants/field-ids/insurance/policy';
+
+const {
+  CONTRACT_POLICY: { REQUESTED_START_DATE },
+} = FIELD_IDS;
+
+/**
+ * assertEmptyRequestedStartDateFieldValues
+ * Assert all REQUESTED_START_DATE field values are empty.
+ */
+const assertEmptyRequestedStartDateFieldValues = () => {
+  field(REQUESTED_START_DATE).dayInput().should('have.value', '');
+  field(REQUESTED_START_DATE).monthInput().should('have.value', '');
+  field(REQUESTED_START_DATE).yearInput().should('have.value', '');
+};
+
+export default assertEmptyRequestedStartDateFieldValues;
diff --git a/e2e-tests/commands/shared-commands/assertions/index.js b/e2e-tests/commands/shared-commands/assertions/index.js
@@ -20,6 +20,7 @@ Cypress.Commands.add('assertNoRadioOptionIsNotChecked', require('./assert-no-rad
 Cypress.Commands.add('assertLength', require('./assert-length'));
 Cypress.Commands.add('assertErrorSummaryListLength', require('./assert-error-summary-list-length'));
 Cypress.Commands.add('assertErrorSummaryListDoesNotExist', require('./assert-error-summary-list-does-not-exist'));
+Cypress.Commands.add('assertCurrencyFormFieldsAreEmpty', require('./assert-currency-form-fields-are-empty'));
 
 Cypress.Commands.add('assertCopyWithCurrencyName', require('./assert-copy-with-currency-name'));
 Cypress.Commands.add('assertPrefix', require('./assert-prefix'));
@@ -84,4 +85,7 @@ Cypress.Commands.add('assertEmptyAgentServiceFieldValues', require('./assert-emp
 Cypress.Commands.add('assertAgentChargesFieldValues', require('./assert-agent-charges-field-values'));
 Cypress.Commands.add('assertEmptyAgentChargesFieldValues', require('./assert-empty-agent-charges-field-values'));
 
+Cypress.Commands.add('assertEmptyContractCompletionDateFieldValues', require('./assert-empty-contract-completion-date-field-values'));
+Cypress.Commands.add('assertEmptyRequestedStartDateFieldValues', require('./assert-empty-requested-start-date-field-values'));
+
 Cypress.Commands.add('submitAndAssertChangeAnswersPageUrl', require('./submit-and-assert-change-answers-page-url'));
diff --git a/e2e-tests/constants/field-ids/insurance/policy/index.js b/e2e-tests/constants/field-ids/insurance/policy/index.js
@@ -83,3 +83,5 @@ export const POLICY = {
   FINANCIAL_ADDRESS: 'bankAddress',
   LOSS_PAYEE_FINANCIAL_ADDRESS: 'lossPayee.bankAddress',
 };
+
+export default POLICY;
diff --git a/...ress/e2e/journeys/account/create/confirm-email/confirm-email-verification-expired.spec.js b/...ress/e2e/journeys/account/create/confirm-email/confirm-email-verification-expired.spec.js
@@ -9,7 +9,10 @@ const {
   START,
   ACCOUNT: {
     CREATE: {
-      CONFIRM_EMAIL, VERIFY_EMAIL, VERIFY_EMAIL_EXPIRED_LINK, CONFIRM_EMAIL_RESENT,
+      CONFIRM_EMAIL,
+      VERIFY_EMAIL,
+      VERIFY_EMAIL_EXPIRED_LINK,
+      CONFIRM_EMAIL_RESENT,
     },
   },
 } = ROUTES;

diff --git a/...iple-policy/change-your-answers-change-policy-type-multiple-to-single-to-multiple.spec.js b/...iple-policy/change-your-answers-change-policy-type-multiple-to-single-to-multiple.spec.js
@@ -0,0 +1,76 @@
+import { field, summaryList } from '../../../../../../../pages/shared';
+import { FIELD_VALUES } from '../../../../../../../constants';
+import FIELD_IDS from '../../../../../../../constants/field-ids/insurance/policy';
+import { INSURANCE_ROUTES } from '../../../../../../../constants/routes/insurance';
+
+const {
+  POLICY_TYPE: { MULTIPLE },
+} = FIELD_VALUES;
+
+const {
+  ROOT,
+  POLICY: { CHECK_YOUR_ANSWERS, MULTIPLE_CONTRACT_POLICY, MULTIPLE_CONTRACT_POLICY_EXPORT_VALUE },
+} = INSURANCE_ROUTES;
+
+const {
+  TYPE_OF_POLICY: { POLICY_TYPE },
+  CONTRACT_POLICY: {
+    MULTIPLE: { TOTAL_MONTHS_OF_COVER },
+  },
+  EXPORT_VALUE: {
+    MULTIPLE: { TOTAL_SALES_TO_BUYER, MAXIMUM_BUYER_WILL_OWE },
+  },
+} = FIELD_IDS;
+
+const baseUrl = Cypress.config('baseUrl');
+
+context('Insurance - Policy - Change your answers - Policy type - multiple to single, then back to multiple', () => {
+  let referenceNumber;
+  let checkYourAnswersUrl;
+  let exportValueUrl;
+
+  before(() => {
+    cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
+      referenceNumber = refNumber;
+
+      cy.completePolicySection({ policyType: MULTIPLE });
+
+      const applicationRouteUrl = `${ROOT}/${referenceNumber}`;
+
+      checkYourAnswersUrl = `${baseUrl}${applicationRouteUrl}${CHECK_YOUR_ANSWERS}`;
+      exportValueUrl = `${baseUrl}${applicationRouteUrl}${MULTIPLE_CONTRACT_POLICY_EXPORT_VALUE}`;
+
+      cy.assertUrl(checkYourAnswersUrl);
+    });
+  });
+
+  beforeEach(() => {
+    cy.saveSession();
+
+    cy.navigateToUrl(checkYourAnswersUrl);
+
+    cy.changePolicyTypeToSingleAndSubmitContractPolicyForm();
+    cy.completeAndSubmitTotalContractValueForm({});
+
+    summaryList.field(POLICY_TYPE).changeLink().click();
+
+    cy.completeAndSubmitPolicyTypeForm({ policyType: MULTIPLE });
+  });
+
+  after(() => {
+    cy.deleteApplication(referenceNumber);
+  });
+
+  it(`should have empty field values when going back to ${MULTIPLE_CONTRACT_POLICY} and ${MULTIPLE_CONTRACT_POLICY_EXPORT_VALUE}`, () => {
+    cy.assertEmptyRequestedStartDateFieldValues();
+
+    field(TOTAL_MONTHS_OF_COVER).input().should('have.value', '');
+
+    cy.assertCurrencyFormFieldsAreEmpty();
+
+    cy.navigateToUrl(exportValueUrl);
+
+    field(TOTAL_SALES_TO_BUYER).input().should('have.value', '');
+    field(MAXIMUM_BUYER_WILL_OWE).input().should('have.value', '');
+  });
+});
diff --git a/...answers/multiple-policy/change-your-answers-change-policy-type-multiple-to-single.spec.js b/...answers/multiple-policy/change-your-answers-change-policy-type-multiple-to-single.spec.js
@@ -1,17 +1,12 @@
 import { summaryList } from '../../../../../../../pages/shared';
-import { typeOfPolicyPage } from '../../../../../../../pages/insurance/policy';
 import { FIELD_VALUES } from '../../../../../../../constants';
 import { INSURANCE_FIELD_IDS } from '../../../../../../../constants/field-ids/insurance';
 import { INSURANCE_ROUTES } from '../../../../../../../constants/routes/insurance';
 import checkSummaryList from '../../../../../../../commands/insurance/check-policy-summary-list';
 
 const {
   ROOT,
-  POLICY: {
-    CHECK_YOUR_ANSWERS,
-    TYPE_OF_POLICY_CHANGE,
-    SINGLE_CONTRACT_POLICY_TOTAL_CONTRACT_VALUE_CHANGE,
-  },
+  POLICY: { CHECK_YOUR_ANSWERS, TYPE_OF_POLICY_CHANGE, SINGLE_CONTRACT_POLICY_TOTAL_CONTRACT_VALUE_CHANGE },
 } = INSURANCE_ROUTES;
 
 const {
@@ -73,12 +68,7 @@ context('Insurance - Policy - Change your answers - Policy type - multiple to si
     beforeEach(() => {
       cy.navigateToUrl(checkYourAnswersUrl);
 
-      summaryList.field(POLICY_TYPE).changeLink().click();
-
-      typeOfPolicyPage[POLICY_TYPE].single.label().click();
-      cy.clickSubmitButton();
-
-      cy.completeAndSubmitSingleContractPolicyForm({});
+      cy.changePolicyTypeToSingleAndSubmitContractPolicyForm();
     });
 
     it(`should redirect to ${SINGLE_CONTRACT_POLICY_TOTAL_CONTRACT_VALUE_CHANGE} because the policy type has changed`, () => {

diff --git a/...single-policy/change-your-answers-change-policy-type-single-to-multiple-to-single.spec.js b/...single-policy/change-your-answers-change-policy-type-single-to-multiple-to-single.spec.js
@@ -0,0 +1,71 @@
+import { field, summaryList } from '../../../../../../../pages/shared';
+import { FIELD_VALUES } from '../../../../../../../constants';
+import { INSURANCE_ROUTES } from '../../../../../../../constants/routes/insurance';
+import FIELD_IDS from '../../../../../../../constants/field-ids/insurance/policy';
+
+const {
+  POLICY_TYPE: { SINGLE },
+} = FIELD_VALUES;
+
+const {
+  ROOT,
+  POLICY: { CHECK_YOUR_ANSWERS, SINGLE_CONTRACT_POLICY, SINGLE_CONTRACT_POLICY_TOTAL_CONTRACT_VALUE },
+} = INSURANCE_ROUTES;
+
+const {
+  TYPE_OF_POLICY: { POLICY_TYPE },
+  CONTRACT_POLICY: {
+    SINGLE: { TOTAL_CONTRACT_VALUE },
+  },
+} = FIELD_IDS;
+
+const baseUrl = Cypress.config('baseUrl');
+
+context('Insurance - Policy - Change your answers - Policy type - single to multiple, then back to single', () => {
+  let referenceNumber;
+  let checkYourAnswersUrl;
+  let totalContractValueUrl;
+
+  before(() => {
+    cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
+      referenceNumber = refNumber;
+
+      cy.completePolicySection({});
+
+      const applicationRouteUrl = `${ROOT}/${referenceNumber}`;
+
+      checkYourAnswersUrl = `${baseUrl}${applicationRouteUrl}${CHECK_YOUR_ANSWERS}`;
+      totalContractValueUrl = `${baseUrl}${applicationRouteUrl}${SINGLE_CONTRACT_POLICY_TOTAL_CONTRACT_VALUE}`;
+
+      cy.assertUrl(checkYourAnswersUrl);
+    });
+  });
+
+  beforeEach(() => {
+    cy.saveSession();
+
+    cy.navigateToUrl(checkYourAnswersUrl);
+
+    cy.changePolicyTypeToMultipleAndSubmitContractPolicyForm();
+    cy.completeAndSubmitExportValueForm();
+
+    summaryList.field(POLICY_TYPE).changeLink().click();
+
+    cy.completeAndSubmitPolicyTypeForm({ policyType: SINGLE });
+  });
+
+  after(() => {
+    cy.deleteApplication(referenceNumber);
+  });
+
+  it(`should have empty field values when going back to ${SINGLE_CONTRACT_POLICY} and ${SINGLE_CONTRACT_POLICY_TOTAL_CONTRACT_VALUE}`, () => {
+    cy.assertEmptyRequestedStartDateFieldValues();
+    cy.assertEmptyContractCompletionDateFieldValues();
+
+    cy.assertCurrencyFormFieldsAreEmpty();
+
+    cy.navigateToUrl(totalContractValueUrl);
+
+    field(TOTAL_CONTRACT_VALUE).input().should('have.value', '');
+  });
+});