Skip to content

fix(ui5-popover): restrict max content height when overflowing the screen #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2019
Merged

fix(ui5-popover): restrict max content height when overflowing the screen #908

merged 2 commits into from
Nov 15, 2019

Conversation

MapTo0
Copy link
Contributor

@MapTo0 MapTo0 commented Nov 5, 2019

FIXES: #853

@MapTo0 MapTo0 requested review from ilhan007 and vladitasev November 5, 2019 11:02
@MapTo0 MapTo0 closed this Nov 5, 2019
@MapTo0 MapTo0 reopened this Nov 5, 2019
@MapTo0 MapTo0 merged commit 6671793 into master Nov 15, 2019
@MapTo0 MapTo0 deleted the popover-max-height branch November 15, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-select should handle screen overflow
2 participants
@MapTo0 @ilhan007