feat(ui5-textarea): implement input event #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
previously requested changes
Jun 17, 2019
ilhan007
requested changes
Oct 17, 2019
packages/main/src/TextArea.js
Outdated
| const nativeTextarea = this.getInputDomRef(); | ||
|
|
||
| /* skip calling change event when an textarea with a placeholder is focused on IE | ||
| - value of the host and the internal textarea should be differnt in case of actual textarea |
There was a problem hiding this comment.
Fix the comments:
-
typo in "differnt" -> different
-
in case of actual "textarea"
(I guess this should be: in case of actual input/typing) -
"textarea" is called when a key is pressed
(I guess this should be: the "input" event is called when a key is pressed)
| } | ||
|
|
||
| this.value = nativeTextarea.value; | ||
| this.fireEvent("input", {}); |
There was a problem hiding this comment.
Should we add "value-change" to make "origami" work?
ilhan007
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.