Skip to content

[ui5-dynamic-page][SF_ACC]: missing aria-label for headerArea slot #12274

@GongRichard

Description

@GongRichard

Bug Description

There defined role="region" for the headerArea slot of ui5-dynamic-page, but there was no aria-label.

Image

Affected Component

ui5-dynamic-page

Expected Behaviour

I think it's better to let the application define the role and aria-label, and we can remove role="region" here.
If it must define role="region" here, it should also define aria-label here. And also, it is better for application to have the capability to customize the aria-label.

Isolated Example

No response

Steps to Reproduce

  1. open sample https://sap.github.io/ui5-webcomponents-react/v2/?path=/story/layouts-floorplans-dynamicpage--default
  2. check the dom of headerArea slot

Log Output, Stack Trace or Screenshots

Image

Priority

Medium

UI5 Web Components Version

2.14.X

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.

Metadata

Metadata

Assignees

Type

Projects

Status

Completed

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions