Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an extra variable that defines the stop stage of a washer/dryer… #1281

Merged

Conversation

Cruguah
Copy link
Contributor

@Cruguah Cruguah commented Apr 17, 2023

… machine

Additional information

To solve the issue of the LG SmartThinQ device we added an extra variable which defines the stop stage of a washer/dryer machine. All machine stage tests are changes to test if the machine state matches the machine stop stage

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the contribution guidelines
    • This PR is for a custom-card or documentation change and therefore directed to the main branch.
    • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

dougmaitelli
dougmaitelli previously approved these changes Apr 17, 2023
@Cruguah Cruguah dismissed stale reviews from basbruss and dougmaitelli via c528af5 April 18, 2023 12:12
@Cruguah
Copy link
Contributor Author

Cruguah commented May 4, 2023

@dougmaitelli and @basbruss, This PR is ready for review/merged to main.
Would you be zo kind to take a look at it, and if agreed, merge it?

@basbruss basbruss merged commit b27e1a3 into UI-Lovelace-Minimalist:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Washer / Dryer card issues for LG SmartThinQ devices
3 participants