Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive improvements #12

Merged
merged 17 commits into from
Oct 20, 2015
Merged

Massive improvements #12

merged 17 commits into from
Oct 20, 2015

Conversation

Daniel-KM
Copy link
Contributor

Hi,

I made massive improvements to your interesting plugin, that I need for another one: normalization of the Entry model, log of collections and files, use of Zend methods to browse entries, possibility to find the last changed element (in fact, i need just the last commit, but it depends on all previous ones). The table is slightly different, but there is an automatic upgrade path, so it can be used directly for old installations.

Sincerely,

Daniel Berthereau
Infodoc & Knowledge management

@NedHenry
Copy link
Contributor

This looks wonderful. This plugin has needed this kind of overhaul rather badly, as do a few of our older plugins which were created primarily for internal use. It looks like your changes make the plugin more useful, better organized, more standardized, and easier to maintain and upgrade. I will merge them as soon as I have a chance to read through your work more thoroughly and do a little testing. Thank you, Daniel!

@NedHenry NedHenry merged commit c73d1ea into UCSCLibrary:master Oct 20, 2015
@NedHenry
Copy link
Contributor

I merged in your improvements, while making a few small changes to fix bugs & typos I found while checkout our your branch. Thanks again for your much needed upgrades to this plugin!

@Daniel-KM
Copy link
Contributor Author

Hi,

Thanks. I'll add some other methods in a few days to make some stats from logs.

Sincerely,

Daniel Berthereau
Infodoc & Knowledge management

@Daniel-KM Daniel-KM deleted the improvements branch October 28, 2015 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants