Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welsh example #23

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Welsh example #23

merged 2 commits into from
Jan 17, 2022

Conversation

apmoore1
Copy link
Member

Adds the following:

  • A mapping from the basic CorCenCC POS tagset to USAS core POS tagset.
  • The usage documentation, for the "How-to Tag Text", has been updated so that it includes a Welsh example which does not use spaCy, instead uses the CyTag toolkit.

Creating a new release

I think once this has been added to the main branch we should create a new release, e.g. 0.2.0 as the new release will contain the following two POS mappings:

  1. A mapping from the basic CorCenCC POS tagset to USAS core POS tagset.
  2. A mapping from the Penn Chinese Treebank POS tagset to USAS core POS tagset.

What do you think @perayson ?

@apmoore1 apmoore1 added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 15, 2022
@apmoore1 apmoore1 requested a review from perayson January 15, 2022 11:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #23 (e6efe4a) into main (854bce6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   97.61%   97.62%           
=======================================
  Files           8        8           
  Lines         336      337    +1     
  Branches       66       66           
=======================================
+ Hits          328      329    +1     
  Misses          7        7           
  Partials        1        1           
Impacted Files Coverage Δ
pymusas/pos_mapper.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854bce6...e6efe4a. Read the comment docs.

@perayson
Copy link
Member

Thanks, this all looks great to me, and I agree about a new release. Will that trigger an update on the pip installable version?

@perayson perayson merged commit 85ac891 into main Jan 17, 2022
@perayson perayson deleted the welsh-example branch January 17, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants