👷 👋👋 Travis - Welcome GH actions #197
Conversation
There was a problem hiding this comment.
Looks good, let's try the deployment in action! Two thoughts:
- If not deploying, can we save the build directory as an artifact, so that we can download and check it if needed?
- Since we're using a custom domain (
github-pages.ucl.ac.uk), do we need to add a CNAME file? Going by the notes on the jekyll action.
| - texlive-generic-recommended | ||
| - texlive-generic-extra |
There was a problem hiding this comment.
Guessing we don't need these in the new setup, but noting in case we need to look at it again in the future!
There was a problem hiding this comment.
they've changed name, they are not in the newest ubuntu, but they were in bionic (three versions ago)
| restore-keys: | | ||
| ${{ runner.os }}-gems- |
There was a problem hiding this comment.
I'm a bit concerned this will lead to weird behaviour if we change the Gemfile dependencies. I would prefer to regenerate the cache in that case. Do we need the restore-keys?
There was a problem hiding this comment.
If we change the dependencies, then the new version will be installed as directed by the gemfile. This will copy the previous version there. In any case, we can always delete the cache.
Imported from UCL-RITS/doctoral-programming-intro#17