Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 👋👋 Travis - Welcome GH actions #197

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Conversation

dpshelio
Copy link
Member

@dpshelio dpshelio commented Oct 3, 2021

Copy link
Contributor

@ageorgou ageorgou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's try the deployment in action! Two thoughts:

  1. If not deploying, can we save the build directory as an artifact, so that we can download and check it if needed?
  2. Since we're using a custom domain (github-pages.ucl.ac.uk), do we need to add a CNAME file? Going by the notes on the jekyll action.

Comment on lines -18 to -19
- texlive-generic-recommended
- texlive-generic-extra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing we don't need these in the new setup, but noting in case we need to look at it again in the future!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they've changed name, they are not in the newest ubuntu, but they were in bionic (three versions ago)

Comment on lines +18 to +19
restore-keys: |
${{ runner.os }}-gems-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned this will lead to weird behaviour if we change the Gemfile dependencies. I would prefer to regenerate the cache in that case. Do we need the restore-keys?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change the dependencies, then the new version will be installed as directed by the gemfile. This will copy the previous version there. In any case, we can always delete the cache.

@dpshelio dpshelio merged commit 11dbaff into UCL:main Oct 5, 2021
@dpshelio dpshelio deleted the travis2gh branch October 5, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants