Code

Prepare for origin shift 2020#618

Code

Open

ashgillman wants to merge 31 commits intoUCL:masterUCL/STIR:masterfrom ashgillman:prepare-for-origin-shift-2020ashgillman/STIR:prepare-for-origin-shift-2020Copy head branch name to clipboard

+1,281-487

Commits

Commits on Jan 5, 2021

• Places that changes need to occur to account for bed position

  

  Richard Brown

  authored and

  ashgillman

  committed
  462d168

  Copy full SHA for 462d168

• [REF] Use m_in_mm instead of t_in_mm in ProjMatrixByBinUsingRayTracing

  ashgillman

  committed
  3032a21

  Copy full SHA for 3032a21

• [REF] Simplify calculation and correction of phi and s_in_mm In ProjMatrixByBinUsingRayTracing

  ashgillman

  committed
  3ea49da

  Copy full SHA for 3ea49da

• [REF] Remove unneeded argument to ray_trace_one_lor()

  ashgillman

  committed
  d4f0d14

  Copy full SHA for d4f0d14

• [REF] Use DiscretisedDensity's index <-> physical space conversions in ProjMatrixByBinUsingRayTracing

  ashgillman

  committed
  22d98e7

  Copy full SHA for 22d98e7

• [REF] Address comments https://github.com/UCL/STIR/pull/260/files/0365f964a565fa488b278e6a5eb20fa337572b11

  ashgillman

  committed
  f8034f0

  Copy full SHA for f8034f0

• FIX: Do better with test_DataSymmetries...

  Show description for dace9a2
  ashgillman

  committed
  dace9a2

  Copy full SHA for dace9a2

• ENH: DSFB_PET_CG to use PDI for physical<->gantry coords

  ashgillman

  committed
  06f2675

  Copy full SHA for 06f2675

• ENH: DSFB_PET_CG to use axial pos 0 always for offset calc.

  ashgillman

  committed
  6dbd3aa

  Copy full SHA for 6dbd3aa

• TST: Don't use symmetries when synthesising sinograms in recon tests

  ashgillman

  committed
  67fed57

  Copy full SHA for 67fed57

• ENH: FBP3DRPR don't auto centre image in scanner.

  ashgillman

  committed
  27a7257

  Copy full SHA for 27a7257

• ENH: Add DD get_image_centre..., move some VOCG functionality up hierarchy

  ashgillman

  committed
  42aa142

  Copy full SHA for 42aa142

• TST: Start of tests for coordinate system mapping.

  Show description for 473a9f4
  ashgillman

  committed
  473a9f4

  Copy full SHA for 473a9f4

• REF: Neaten up tests a bit before adding FOV tests

  ashgillman

  committed
  40447f8

  Copy full SHA for 40447f8

• TST: Add tests comparing projectors - currently failing but correctly so.

  ashgillman

  committed
  e073170

  Copy full SHA for e073170

• TST: FOV tests comparing projectors working, only RT and Interp Matrix included

  ashgillman

  committed
  ede7d51

  Copy full SHA for ede7d51

• ENH: PMBBUI uses PDI for gantry-space conversions, supports non-axially-centred images.

  ashgillman

  committed
  c3442a0

  Copy full SHA for c3442a0

• FIX: Forgot to push RunTests's VectorWithOffset iterator check

  ashgillman

  committed
  3f290eb

  Copy full SHA for 3f290eb

• REF: Decouple PMBBURT a little more from DD members

  ashgillman

  committed
  0515d89

  Copy full SHA for 0515d89

• FIX: Failures in some tests.

  ashgillman

  committed
  35b5340

  Copy full SHA for 35b5340

• REF: Updated PDICNAC functions

  Show description for d1ded0e
  ashgillman

  committed
  d1ded0e

  Copy full SHA for d1ded0e

• REF: Fix some variables that are actually in gantry_coords

  ashgillman

  committed
  d887601

  Copy full SHA for d887601

• DOC: Some potential new TODOs

  ashgillman

  committed
  df48818

  Copy full SHA for df48818

• REF: Remove some unnecessary TODO items

  ashgillman

  committed
  f3ee74b

  Copy full SHA for f3ee74b

• ENH: Densels Symmetries - use coordinate system transform funtions

  ashgillman

  committed
  7a4d8ec

  Copy full SHA for 7a4d8ec

• FIX: Scatter Integrals - no need to shift origin

  ashgillman

  committed
  d58124c

  Copy full SHA for d58124c

• REF: Use image function for centre

  ashgillman

  committed
  5d38ee2

  Copy full SHA for 5d38ee2

• FIX: Logic error with gantry offset. gantry.z + ring_to_centre = ring_coord

  ashgillman

  committed
  a2fc8e7

  Copy full SHA for a2fc8e7

• REF: Make Scatter coord systems more explicit

  ashgillman

  committed
  a48638c

  Copy full SHA for a48638c

• FIX: Small scatter issues

  ashgillman

  committed
  86d9049

  Copy full SHA for 86d9049

• FIX: Old bug in downample_scanner doesn't preserve scanner length correctly

  ashgillman

  committed
  886c95f

  Copy full SHA for 886c95f