Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling to read TOF-bin order from Interfile Header #1389

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

NicoleJurjew
Copy link
Contributor

Changes in this pull request

With this change, the "TOF bin order" is assigned from the keyword in Interfile Headers.

Testing performed

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • [] I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

@KrisThielemans
Copy link
Collaborator

Thanks

If easy, could you run clang-format? As you're on Ubuntu 22.04

sudo apt install clang-format
python3 -m pip install pre-commit
cd /blabla/STIR
pre-commit run --allfiles

(normally you'd only do pre-commit run, but I guess we need --all-files you have committed already)
but I can do this as well.

Also, add a "new feature" item in `release_6.1.htm.

@NicoleJurjew
Copy link
Contributor Author

Sorry, hope this works now! thanks for the explanation!

@KrisThielemans
Copy link
Collaborator

great. thanks.

@KrisThielemans KrisThielemans merged commit 0da0f08 into UCL:master Feb 16, 2024
8 of 9 checks passed
@KrisThielemans KrisThielemans deleted the tof_bin_order_Interfile branch February 16, 2024 17:25
@KrisThielemans
Copy link
Collaborator

I've squash-merged this. sorry. So, checkout master and pull. Then delete your tof_bin_order_Interfile branch.

@NicoleJurjew NicoleJurjew restored the tof_bin_order_Interfile branch April 12, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants