Expose listmode reconstruction in SWIG and fix an issue with cache naming #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrisThielemans
approved these changes
Oct 2, 2023
|
Yes, I have completed my first listmode reconstruction today and it looks good! Took a long time, though: approximately 9 minutes per set of 10 sub-iterations |
|
ok great. we can discuss timing later. would be good to have some idea of difference in timing when creating the cache vs re-using it. Also, we should really switch to non-view subsets, such that we can use many more, but that's another PR! |
markus-jehl
deleted the
issue/1268-listmode-reconstruction-creates-cache-files-with-wrong-numbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1268 and makes listmode reconstruction callable from python.