Better CMake warnings and messages #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set CMP0074 to NEW (which will avoid warning about BOOST_ROOT) - explicitly use CONFIG mode in find_package for ITK, parallelproj and nlohmann_json to let CMake give a clearer message what needs to be done (i.e. set *_DIR) - warn about parallelproj < 1.2.13 - improve a few messages
KrisThielemans
force-pushed
the
better_CMake_warnings
branch
from
57cb14d
to
29f46cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently based on #1137 but will rebase