Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

effective central bin size in the Interfile header #1034

Closed
KrisThielemans opened this issue May 9, 2022 · 0 comments · Fixed by #1372
Closed

effective central bin size in the Interfile header #1034

KrisThielemans opened this issue May 9, 2022 · 0 comments · Fixed by #1372
Labels
enhancement
Milestone
v6.0

Comments

@KrisThielemans
Copy link
Collaborator

found by @danieldeidda

We currently write an "effective central bin size" to the interfile header in all cases, but really only use it for the arc-corrected case (we write some warnings if it's not as expected, but that's the only thing we do with it). However, for a block/generic scanner, this concept makes no sense really. The central bin could be just next to a gap for instance. The keyword should really only be written (and read) for the arc-corrected case therefore.
@KrisThielemans KrisThielemans added this to the v6.0 milestone May 9, 2022
KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this issue Feb 7, 2024
@KrisThielemans
Interfile: mostly ignore "effective central bin size" keyword
fa06c2c 
This keyword only makes sense for arc-corrected data. Therefore, we now
only read/write it in that case.

Fixes UCL#1034
@KrisThielemans KrisThielemans mentioned this issue Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v6.0
Development

Successfully merging a pull request may close this issue.

6.0.0 final preparation KrisThielemans/STIR-1
1 participant
@KrisThielemans