-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typhoid vignette #9
Conversation
Loaded datasets and began updating explanatory text.
vignettes/typhoid-seroincidence.Rmd
Outdated
##Load simulated data (lambda = .2) and prepare for model | ||
The simulated data are assuming a force of infection (FOI, *lambda*) of 0.2. We have selected hlye and IgG as our target measures. From the original dataset, we rename our variables to ______. Finally, we once again limit the dataset to only the variables needed for the analysis. | ||
``` {r simdata} | ||
p.hlye.IgG <- read_csv("simpophlyeigg.2.csv") %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the checks are currently failing due to this line; fix a la https://r-pkgs.org/data.html#sec-data-system-file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close to ready for merge! I left some in-line comments for details to iron out.
vignettes/installation.Rmd
Outdated
@@ -127,19 +127,19 @@ by executing one of the following commands in the *R console*: | |||
```{r, include=FALSE, tidy=FALSE} | |||
chunkTemplate <- "```{r, eval = FALSE} | |||
# OPTION A | |||
# Install Windows binary package \"seroincidence\" directly from internet ECDC website: | |||
# Install Windows binary package \"serocalculator\" directly from internet ECDC website: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this option should be changed to point to github instead of ECDC
README.md
Outdated
|
||
**A Note for Windows Users** | ||
|
||
Windows users will need to install Rtools, which contains a collection of tools for building and employing R packages that are still in development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the version of Rtools installed by devtools not work? I can't remember what happened with that.
@kristinawlai I pushed some commits to the |
@d-morrison The changes are too complex to resolve in the web editor, so I can't see what to edit. Can you show me how to do this via command line or other best way to do this? We can discuss on our call. |
Updated typhoid vignette data loading and started updating explanatory text.