Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typhoid vignette #9

Closed
wants to merge 5 commits into from
Closed

Conversation

kristinawlai
Copy link
Collaborator

Updated typhoid vignette data loading and started updating explanatory text.

Loaded datasets and began updating explanatory text.
##Load simulated data (lambda = .2) and prepare for model
The simulated data are assuming a force of infection (FOI, *lambda*) of 0.2. We have selected hlye and IgG as our target measures. From the original dataset, we rename our variables to ______. Finally, we once again limit the dataset to only the variables needed for the analysis.
``` {r simdata}
p.hlye.IgG <- read_csv("simpophlyeigg.2.csv") %>%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the checks are currently failing due to this line; fix a la https://r-pkgs.org/data.html#sec-data-system-file ?

Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close to ready for merge! I left some in-line comments for details to iron out.

@@ -127,19 +127,19 @@ by executing one of the following commands in the *R console*:
```{r, include=FALSE, tidy=FALSE}
chunkTemplate <- "```{r, eval = FALSE}
# OPTION A
# Install Windows binary package \"seroincidence\" directly from internet ECDC website:
# Install Windows binary package \"serocalculator\" directly from internet ECDC website:
Copy link
Member

@d-morrison d-morrison Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this option should be changed to point to github instead of ECDC

README.html Outdated Show resolved Hide resolved
README.md Outdated

**A Note for Windows Users**

Windows users will need to install Rtools, which contains a collection of tools for building and employing R packages that are still in development.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the version of Rtools installed by devtools not work? I can't remember what happened with that.

@d-morrison
Copy link
Member

@kristinawlai I pushed some commits to the typhoid_vignette branch on your fork to try to fix the check errors we were getting, but there are some file conflicts that I can't resolve (since we're still operating on your fork for now). Would you please take a look and try to sort them out? There should be a "Resolve conflicts" button somewhere on the this page, which will take you to an online file editor. The html file just needs to be deleted, so that will hopefully be simple to resolve, but in the typhoid-seroincidence.Rmd file, there might be some strange-looking markings showing the line-by-line conflicts. Take a look at those and see if you can edit the file to how you think it should be? If you get stuck, please let me know!

@kristinawlai
Copy link
Collaborator Author

@d-morrison The changes are too complex to resolve in the web editor, so I can't see what to edit. Can you show me how to do this via command line or other best way to do this? We can discuss on our call.

@d-morrison d-morrison closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants