Debug curve plot #323
Merged
Debug curve plot #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📖 https://ucd-serg.github.io/serocalculator/preview/pr323 |
|
@sschildhauer please review this PR; this is a good opportunity to get you up to speed on github code review |
d-morrison
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
d-morrison
commented
Dec 20, 2024
| ab0 <- function( | ||
| t, | ||
| curve_params) { | ||
| ab0 <- function(t, curve_params) { |
d-morrison
commented
Dec 20, 2024
| y0 <- curve_params[["y0"]] | ||
| y1 <- curve_params[["y1"]] | ||
| t1 <- curve_params[["t1"]] | ||
| alpha <- curve_params[["alpha"]] | ||
| shape <- curve_params[["r"]] | ||
| r <- curve_params[["r"]] |
There was a problem hiding this comment.
shortening varname to make lines below fit in less than 80 characters
d-morrison
commented
Dec 20, 2024
|
|
||
| beta <- bt(y0, y1, t1) | ||
|
|
||
| yt <- 0 | ||
|
|
||
| yt_phase_1 <- y0 * exp(beta * t) | ||
| yt_phase_2 <- (y1^(1 - shape) - (1 - shape) * alpha * (t - t1))^(1 / (1 - shape)) | ||
| if (r == 1) { |
There was a problem hiding this comment.
if r == 1, the usual expression for this function reduces to 0^Inf = 0, which isn't correct; as r -> 1, the function should reduce to the exponential.
kristinawlai
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes UCD-SERG/shiny_decay_curve#4 by handling r = 1 case specially;
$y(t) = y_1 e^{-v(t-t_1)}$
is undefined when r = 1, but the limit is