Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polishing edits on pr #234 #305

Merged

Conversation

d-morrison
Copy link
Member

@d-morrison d-morrison commented Oct 7, 2024

Edits to #234:

  • simplify package installation instructions in vignette
  • add to changelog in NEWS.md

@d-morrison d-morrison changed the title Pr/234/patch 01 pr/234/patch-1 Oct 7, 2024
@d-morrison d-morrison changed the title pr/234/patch-1 polishing edits on pr #234 Oct 7, 2024
@d-morrison d-morrison marked this pull request as ready for review October 7, 2024 08:51
@d-morrison d-morrison requested a review from chrisorwa October 7, 2024 08:53
Copy link
Collaborator

@chrisorwa chrisorwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@chrisorwa chrisorwa merged commit 44042fc into improve-autoplotpop_data-error-communication Oct 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants