-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write_idt_plate_excel_file uses reasonable defaults even when some strands have no IDT field set #111
Labels
enhancement
New feature or request
Comments
Closed
dave-doty
changed the title
add option to avoid requiring a call to set_default_idt on each Strand before calling write_idt_plate_excel_file
add option to avoid requiring to set IDT fields on each Strand before calling write_idt_plate_excel_file
Dec 15, 2020
dave-doty
added a commit
that referenced
this issue
Dec 16, 2020
…ver, since issue #111 still need to be implemented)
In implementing this, I made some changes worth noting in the release notes. In particular: The main change is that it is no longer necessary to modify the design to set the field import scadnano as sc
design = sc.Design(helices=[sc.Helix(max_offset=100) for _ in range(2)], grid=sc.square)
design.strand(0, 0).move(8).cross(1).move(-8)
design.strand(0, 16).move(-8).cross(1).move(8)
design.assign_dna(strands[0], 'A'*16)
design.assign_dna(strands[1], 'C'*16)
# before the change, the next line would have skipped writing the two strands since they have no idt field set,
# now, reasonable defaults are used, without requiring the side-effect of writing the field Strand.idt
design.write_idt_plate_excel_file()
# to skip exporting strands that lack an idt field, specify the parameter only_strands_with_idt
# below, only the newly added strand with T's will be exported; the previous two will not
design.strand(0, 24).move(8).cross(1).move(-8).with_idt('only_strand_to_export')
design.assign_dna(strands[2], 'T'*16)
design.write_idt_plate_excel_file(only_strands_with_idt=True)
|
dave-doty
changed the title
add option to avoid requiring to set IDT fields on each Strand before calling write_idt_plate_excel_file
write_idt_plate_excel_file uses reasonable defaults even when some strands have no IDT field set
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, if no IDT fields are set on any strand, then
write_idt_plate_excel_file
will not export any of them. The way to give them a default IDT field for export is to set their IDT fields, either directly or by callingStrand.set_default_idt
.It would be convenient to have
write_idt_plate_excel_file
have an option to temporarily set these for all staples (not scaffold), i.e., just use a default value foridt
without setting it, so thatwrite_idt_plate_excel_file
can simply be called without having to first modify the Strands.The text was updated successfully, but these errors were encountered: