Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move navbar above tab panes in web interface #72

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

zuphilip
Copy link
Member

@zuphilip zuphilip commented Dec 11, 2017

Previous:

navbar-now

With this PR:

navbar-move

@stweil
Copy link
Member

stweil commented Dec 11, 2017

While improving the look-and-feel: displaying the release tag might also be a good idea. Maybe at the right side of the black bar?

@zuphilip
Copy link
Member Author

Agree on this idea. But I am not skilled enough to read the info automatically into this html. Any help?

@zuphilip
Copy link
Member Author

Or maybe just postpone it as an issue?

@kba
Copy link
Collaborator

kba commented Dec 11, 2017

Getting revision info into the web assets would require a build step or reliance on convention or installation. Not hard but finicky and nothing to do with this PR IIUC.

I liked the tabs as they were, but not enough to oppose this :)

@kba kba merged commit f3ea365 into UB-Mannheim:master Dec 11, 2017
@zuphilip zuphilip deleted the navbar-top branch December 11, 2017 12:50
@zuphilip
Copy link
Member Author

( I prefer to click from top-to-bottom and left-to-right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants