Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of suggestions #106

Open
9 of 24 tasks
Jay-o-Way opened this issue Mar 19, 2024 · 4 comments
Open
9 of 24 tasks

Collection of suggestions #106

Jay-o-Way opened this issue Mar 19, 2024 · 4 comments
Labels
Feature Enhancement Update existing feature help wanted Extra attention is needed Tracking Issue
Milestone

Comments

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Mar 19, 2024

Global

BrowserSelection

Ruleset / Edit window

  • Maybe use only a InfoBadge ? 6️⃣ #NoPriority
  • Replace "... (Browser)" with the icon of the browser? β†’ saves space #NoPriority
  • ScrollViewer: full width and don't use a padding β†’ UI improvements - round 1Β #137
  • "found" 6 rules
  • move buttons inside the expander main area
  • Don't use *.google.com as a placeholder. It looks exactly like actual data.
  • After Add event, the Input control should be cleared and have focus, ready for quick entry for next rule input

Test window

  • Result for "Test against existing rule" should be as close to the button as possible.
  • use a control like an InfoBar to display succes/fail, not a color.
  • This window has a very different feeling from the Edit window.
  • Also print the ruleset name.
@U-C-S
Copy link
Owner

U-C-S commented Mar 19, 2024

Thanks once again for taking time to point out the issues.

Working on stability and documentation ones for now, Rest I shall come back to later

U-C-S added a commit that referenced this issue Mar 19, 2024
@Jay-o-Way
Copy link
Contributor Author

Which two points are good for me to pick up (or help you with) ?

@U-C-S
Copy link
Owner

U-C-S commented Apr 2, 2024

Oh didnt see your earlier message πŸ˜…. But you went and did it anyway.

These 2 would be great.

  • Control RulesetAccordion shouldn't be needed
  • move [edit/move/delete] buttons inside the expander main area: always accessible, even when collapsed

Also, I am planning for a rewrite of Hurl.BrowserSelector, which I feel is a mess of code. I will try implement most stuff along the way then. I am also trying design a new icon in figma (#37).

@U-C-S U-C-S added help wanted Extra attention is needed Feature Enhancement Update existing feature Tracking Issue labels Apr 2, 2024
@Jay-o-Way
Copy link
Contributor Author

Now that I've worked a bit on the code, that control isn't so bad. I would use a list, but that's not too difficult. I would also like to try and work on hardcoded colors, margins/paddings and so on.

@U-C-S U-C-S added this to the v0.9 milestone May 16, 2024
@U-C-S U-C-S modified the milestones: v0.9, v0.10 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Update existing feature help wanted Extra attention is needed Tracking Issue
Projects
None yet
Development

No branches or pull requests

2 participants