Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription metadata fix #934

Merged
merged 2 commits into from
May 27, 2023
Merged

Subscription metadata fix #934

merged 2 commits into from
May 27, 2023

Conversation

Tzahi12345
Copy link
Owner

@Tzahi12345 Tzahi12345 commented May 27, 2023 •
edited
Loading

  • Fixed issue where metadata was attempting to be written to a dir that didn't exist yet
  • Fixed issue where sub was assumed as duplicate always if using local db

github-advanced-security[bot]
github-advanced-security bot found potential problems May 27, 2023
View reviewed changes
backend/subscriptions.js
@@ -491,6 +491,8 @@
: config_api.getConfigItem('ytdl_subscriptions_base_path');
const appendedBasePath = getAppendedBasePath(sub, basePath);
const metadata_path = path.join(appendedBasePath, CONSTS.SUBSCRIPTION_BACKUP_PATH);

fs.ensureDirSync(appendedBasePath);

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1). This path depends on a [user-provided value](2).
@Tzahi12345 Tzahi12345 merged commit 13a03a7 into master May 27, 2023
myrenyang pushed a commit to myrenyang/VideoDownloader that referenced this pull request Apr 24, 2024
@Tzahi12345
Subscription metadata fix (Tzahi12345#934)
098ec56 
* Fixed issue where metadata was attempting to be written to a dir that didn't exist yet
* Fixed issue where sub was assumed as duplicate always if using local db

(cherry picked from commit 13a03a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tzahi12345