Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warm up system playlists if they report themselves unavailable on the first request #855

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Dec 30, 2024

Related to #854

@Tyrrrz Tyrrrz requested a review from Copilot December 30, 2024 11:12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

YoutubeExplode/Playlists/PlaylistController.cs:108

  • [nitpick] The condition 'retriesRemaining >= 5' seems arbitrary. Consider making the retry count configurable or document why this specific number was chosen.
if (index <= 0 && string.IsNullOrWhiteSpace(visitorData) && retriesRemaining >= 5)

YoutubeExplode/Playlists/PlaylistController.cs:106

  • [nitpick] The comment could be clearer. Mention that the retry mechanism is specifically for warming up system playlists.
// Some system playlists are unavailable through this endpoint until their page is opened by
@Tyrrrz Tyrrrz requested a review from Copilot December 30, 2024 11:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Tyrrrz Tyrrrz merged commit 8ba5671 into master Dec 30, 2024
7 checks passed
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (30ba3f2) to head (a069f6a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #855   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant