Fix target frameworks for MemberNotNullAttribute and MemberNotNullWhenAttribute
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation, these attributes weren't added until .NET 5. - https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.membernotnullattribute?view=net-8.0#applies-to - https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.membernotnullwhenattribute?view=net-8.0#applies-to
|
Thanks a lot! Nice catch |
Tyrrrz
changed the title
MemberNotNullAttribute and MemberNotNullWhenAttribute
|
I'm going to release it as part of a new version on thursday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version doesn't include
MemberNotNullAttributeandMemberNotNullWhenAttributefor .NET Standard 2.1 or .NET Core 3.1 projects, but if you try to use them from such projects, you get compiler errorCS0122: inaccessible due to its protection level.According to the documentation, these attributes weren't added (or more accurately, made public) until .NET 5:
This pull request moves these two files to the
Net50folder and fixes their#ifdirectives.