fix: assert_line_count on multiline #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chemaclass
requested review from
cmayo,
khru,
JesusValeraDev,
antonio-gg-dev and
fabriziofs
Chemaclass
force-pushed
the
fix/assert-line-count-2
branch
from
28e0735 to
4925501
Compare
staabm
reviewed
Jun 18, 2024
| @@ -318,8 +318,9 @@ function assert_greater_or_equal_than() { | |||
|
|
|||
| function assert_line_count() { | |||
There was a problem hiding this comment.
I feel sorry for opening this can of worms :-).
thanks for working thru all these problem.
There was a problem hiding this comment.
You opened a pandora box... nah, it is also fun - even though I really dislike bash 😝
There was a problem hiding this comment.
"you just need to count the lines" - they said
fabriziofs
reviewed
Jun 18, 2024
fabriziofs
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Issue: phpstan/phpstan-src#3160 (comment)
Multiline strings are passes as multiple args to
assert_line_countwhich makes it complicated to pass around and manipulate as unique string.🔖 Changes
assert_line_countuses first arg for the expected and the rest (think about avariadic ...string arg) will be the string itself that will be use to count its lines.💡 Extra
Tradeoff: I had to rollback #262 in order to make it working. I think I can make it back again, but it might take another couple of hours... so, I thought to ship this first, make it work, and then in a follow up make it better.