Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow calling assertions outside tests #258

Merged
merged 19 commits into from
Jun 17, 2024
Merged

Allow calling assertions outside tests #258

merged 19 commits into from
Jun 17, 2024

Conversation

Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Jun 16, 2024 •
edited
Loading

📚 Description

Issue: #257

🔖 Changes

  • Add an option -a|--assert to ./bashunit to allow running an assertion from bashunit without the test context
  • Benefits: provides the visual output from bashunit assertions + the result exit code is 0(pass) or 1(fail)

✅ To-do list

  • I updated the CHANGELOG.md to reflect the new feature or fix
  • I updated the documentation to reflect the changes

🖼️ Screenshots

Screenshot 2024-06-16 at 13 44 37 Screenshot 2024-06-16 at 23 49 57

@Chemaclass Chemaclass added the enhancement New feature or request label Jun 16, 2024
@Chemaclass Chemaclass self-assigned this Jun 16, 2024
@Chemaclass Chemaclass mentioned this pull request Jun 16, 2024
Merged
@ondrejmirtes
Copy link

Awesome!

@Chemaclass Chemaclass marked this pull request as ready for review June 16, 2024 21:51
@Chemaclass Chemaclass requested a review from staabm June 16, 2024 21:51
@Chemaclass Chemaclass mentioned this pull request Jun 16, 2024
Closed
Chemaclass
Chemaclass commented Jun 16, 2024
View reviewed changes
src/default_env_config.sh Outdated Show resolved Hide resolved
bashunit Outdated Show resolved Hide resolved
staabm
staabm reviewed Jun 17, 2024
View reviewed changes
docs/standalone.md Outdated Show resolved Hide resolved
staabm
staabm approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its awesome, thank you.

Chemaclass and others added 2 commits June 17, 2024 10:55
@Chemaclass @staabm
Update docs/standalone.md
103650a 
Co-authored-by: Markus Staab <maggus.staab@googlemail.com>
@Chemaclass
docs: update changelog
af95e02
@Chemaclass Chemaclass merged commit a6dd402 into main Jun 17, 2024
7 checks passed
@Chemaclass Chemaclass deleted the feat/257-allow-calling-assertions-outside-tests branch June 17, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khru khru khru approved these changes

@antonio-gg-dev antonio-gg-dev antonio-gg-dev approved these changes

@JesusValeraDev JesusValeraDev JesusValeraDev approved these changes

@staabm staabm staabm approved these changes

@cmayo cmayo Awaiting requested review from cmayo

Assignees

@Chemaclass Chemaclass

Labels
enhancement New feature or request
Projects
bashunit
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Chemaclass @ondrejmirtes @staabm @khru @JesusValeraDev @antonio-gg-dev