Support Bash "strict mode" (and fix one unit test) #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few different kinds of changes are made:
- Optional parameters/variables are changed to ${var-} to default to
empty or given defaults with ${var=...}.
- ((...)) arithmetic evaluation "fails" when the result happens to be
zero, so silence this with "|| true"
This will help ensure that bashunit won't cause problems with tests that use "set -euo pipefail"
Watermelon AI SummaryAI Summary deactivated by djpohly GitHub PRs
bashunit is an open repo and Watermelon will serve it for free. |
antonio-gg-dev
requested review from
khru,
Chemaclass,
antonio-gg-dev and
cmayo
Chemaclass
approved these changes
Dec 22, 2023
|
It seems that it is not working as expected for macos... I will check it out when I find some time these days |
|
I will merge this branch into an internal one with the same name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Some script authors like to use "unofficial Bash strict mode", enough so that supporting it shows up in comparisons of shell testing frameworks.
Case in point: enabling the -u option uncovered a bug in
test_unsuccessful_assert_is_directory_not_writablethat is fixed in this PR.🔖 Changes
set -euo pipefailenabled.$a_filewas supposed to be$a_directory).((...)), which exit 1 if their result happens to be zero, are fixed with|| true.check_duplicate_functionsdoes not appear to be intended to cause the script to fail, so it is also silenced with|| true.${1-}."${varname=default}".set_up) will not be run instead.✅ To-do list
CHANGELOG.mdto reflect the new feature or fixI updated the documentation to reflect the changes(Not sure there's anything to document, since this fix doesn't require users to do anything different.)