Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attempt to fix issue with navigation links on mobile #2548

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

HarelM
Copy link
Contributor

@HarelM HarelM commented Apr 16, 2024

Fixes #2547

I'm opening this PR for initial review of the solution.
The idea was to move the navigation links to the same place as the sidebar links on mobile devices.
I have added the navigation links to the sidebar links.
I have removed the toolbar links on mobile using css.
I have changed the css so that navigation links are not displayed in the sidebar when not on mobile device.

I have tested by coping the resulting build to my project's node_modules.

Before:
image
image

After:
image
image
image

@HarelM
Copy link
Contributor Author

HarelM commented Apr 16, 2024

I've updated the comment above with screen shots of before and after.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 27, 2024

Very nice, thank you!

@Gerrit0 Gerrit0 merged commit eb363a2 into TypeStrong:master Apr 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header is navbar on mobile is overriding itself
2 participants