Fix Issue 939 #942
Merged
Fix Issue 939 #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konpikwastaken
force-pushed
the
fix(issue339)
branch
from
c894d51 to
b365478
Compare
|
Awesome work! I'm away camping right now and so can't take a look at this at the moment. If I haven't reviewed it by the end of next week then please ping me to remind me 😄 Thanks for your efforts! |
|
The issues failing tests seem to be related to missing jasmine types, shouldn't be anything related to my change. Any suggestions to re-queue or fix? |
|
Today TypeScript 3.5.1 has been released, I upgraded tsc, run into Thanks to @konpikwastaken and @johnnyreilly for the quick works! |
I've requeued - let's see where it goes! |
There was a problem hiding this comment.
This looks good - could you:
Update the execution test to require TypeScript version 3.5.1 please?
Could you also update the .travis.yml and appveyor.yml to include TypeScript 3.5.1 in the test matrix?
Also, could you update the version in the package.json - I'm guessing this will be a fix version number?
And could you update the changelog.md too please?
Thanks!
|
@johnnyreilly Have the changes you asked staged, will push soon. I investigated the test failures - looks like the tl;dr; Setting this internal field has side effects in earlier typescript versions, breaking existing tsconfigs. Are you comfortable doing a version check and setting field on tsc>3.5.0? |
Sounds like a solid strategy. If this gains us passing tests then I think going with this should be fine; we can always adjust later if there's issues. |
johnnyreilly
requested changes
May 30, 2019
jasongrout
added a commit
to jasongrout/jupyterlab
that referenced
this pull request
May 31, 2019
See TypeStrong/ts-loader#942. I think this can be deleted once that PR is merged and released.
jasongrout
added a commit
to jasongrout/jupyterlab
that referenced
this pull request
May 31, 2019
See TypeStrong/ts-loader#942. I think this can be deleted once that PR is merged and released.
johnnyreilly
approved these changes
May 31, 2019
|
I wouldn't normally attempt to ship a release whilst camping but it looks like people may be being impacted by not having this.... It's actually not a massive change in the end and we have passing tests so I think I'm going to try and push 6.0.2 out. However, if it causes problems I'm not going to be able to do anything about them... A Google Pixel will only get you so far 😁 Fingers crossed 🤞 |
|
https://github.com/TypeStrong/ts-loader/releases/tag/v6.0.2 should appear on npm in the next 30 mins. Thanks for your work! |
|
Thanks to both of you! |
jasongrout
added a commit
to jasongrout/jupyterlab
that referenced
this pull request
May 31, 2019
This was causing some tests to fail with the ts 3.5.1 upgrade.
saulshanabrook
added a commit
to jupyterlab/jupyterlab-data-explorer
that referenced
this pull request
Jun 6, 2019
cf984351d Merge pull request #6462 from blink1073/release-notes 0b45a77ff Merge pull request #6470 from vatlab/doc 40cdaa0de Merge pull request #6466 from zerline/issue#6452 f3cde924c Merge pull request #6464 from nokome/patch-1 ac7acb35c Remove obsolete documentation on "keymap" interface c250b1530 Merge pull request #6468 from afshin/issue-6408 4bad9c3ba Merge pull request #6467 from zerline/issue#6455 df1b9f0ad Remove `silent` flag for router navigation, always use pushState. ea718f2aa Don't bother changing the URL there is no `token` parameter. db7ee7fec Terminal opens on place. Fixes #6455. 456730b8a No more keypress/keydown confusion (no more keypress). Fixes #6452. 57a87f48d Fix minor typo in documentation a3d6c9453 more release cleanup cd5384d8a Publish v1.0.0a6 31407ecb5 New version 2a3644a52 Merge pull request #6445 from blink1073/release-fixes 83a50c17e revert puppeteer hack 0651857bd Avoid downloading chromium 2b7df7834 Avoid downloading chromium 62afefbeb release cleanup 36f44d904 Merge pull request #6450 from blink1073/fix-examples-again edf004a6b revert to master travis_script a99186a6b remove artifacts from another branch 582b8af98 clean up travis script e762daa5e fix run_test 4d3027330 clean up the app runner 6978027e1 Merge pull request #6454 from jasongrout/tabzone 6aed8efa6 Update phosphor packages. 85c872efb Merge pull request #6447 from ian-r-rose/audit-accel 54b8041db Revert close-and-cleanup keyboard shortcut change, as it conflicts on macs. aafa0b87c Remove schemaDir from help-extension. 4817b7d19 Add close-and-cleaner for terminal. f854fe5f9 Allow "Close and Cleanup" to apply a bit more generally. be58349a7 Use Accel instead of Ctrl where appropriate. 2f5d8dbd4 Remove unused command and keyboard shortcut. 161233283 Merge pull request #6414 from blink1073/fix-app-example 21437fb76 Remove superfluous extension requirement. 0bf189b4a Merge pull request #6440 from jasongrout/ts351 3c7dd6a7d Bump jupyterlab_server dependency. 08c84df9a Fix notebook example. e0c214cde Merge pull request #6444 from capslockwizard/master 11ef71230 Bump server dependency. fd50ceb29 log a normal exit 83d000e94 Use frontendUrl from jupyterlab_server: https://github.com/jupyterlab/jupyterlab_server/pull/65 20dbed376 fix syntax 930fefe15 Fix test app name and add logging f9e1b6410 JupyterLab.IOptions is optional when instantiating JupyterLab. 58deb394d Modified Markdown cells' overflow to "auto" 76cdaf1bf Upgrade ts-loader to fix https://github.com/TypeStrong/ts-loader/pull/942 850e950fc Bump jupyterlab_server dependency. 79933e720 Fix typing errors caught in ts 3.5 c3a1a2c04 Log workspace fetch errors instead of using console.warn. 84dab3a34 Clean up. 6895a6d60 Merge branch 'master' into fix-app-example a369187e0 Remove concept of `defaultWorkspace`. It can be handled transparently. 8a20584ff Remove superfluous argument. 9609d4344 Allow state database extension to work without window resolver. b3ec2988a Update example app configuration (this may need to change) 980c346c1 Upgrade to typescript 3.5.1 d178a35bf Merge pull request #6438 from jasongrout/changelog1a5 e0bf578fc update changelog to reflect 1.0a5 release, the good release. 759515905 Publish 1.0.0a5 aba843df7 New version c40903dee Update changelog. 56e2f3e9d Merge pull request #6437 from jasongrout/prepublish f13d997ed Don’t use npm prepare script for consistency. 03d7b6576 integrity updates (add prepublish scripts) e58b3d56e Ensure there is a prepublishOnly step in each package. 05067699a Publish 1.0.0a4 94536497f New version 6df5e1d4d Merge pull request #6430 from jasongrout/changeloga4 874cbedf4 use passed-in param ef529a2e7 fixup b49a6c308 Merge pull request #6424 from blink1073/raises-exception c3980b544 fix invocation cfc8ebda9 Merge pull request #6412 from jasongrout/kernelmessages 6d968b177 cleanup logic 5e1d933cd Very rough changelog for the next alpha, alpha 4. 0c263166c Fix test compilation errors. 94c25b220 Merge pull request #6429 from domoritz/fix-6403 ac593712d Merge pull request #6382 from cnydw/one-inspect-message 513064e86 Eliminate the poorly typed test function createMsg. dc75f4580 Merge pull request #6312 from blink1073/patch-release-cleanup e325e2e25 Add version to Vega extension ID 8830cb883 Merge pull request #6426 from afshin/sanitize-strings 8bd3f4fe5 Fix test error. 6094532cb Better error message when git status shows the repo is dirty when bumping version. 2fbe4d1cc typo: p -> pre cae18cdd8 Lint fixes 320300b59f Abort if lerna version didn’t commit. b45714f11 More friendly error message cde7a2901 Fix lerna typo 5c6429782 Add a table of version bumping to the release docs. e1a481e51 Install twine and the right version of tornado when doing a release. f1ed16b57 Check for untracked files before building. 328454224 Merge remote-tracking branch 'origin/master' into patch-release-cleanup 4506deec5 Typecheck createMessage arguments. 6283e6b97 Audit innerHTML usage and sanitize inputs. 548d8857a stop the app fc20e3d19 refactor bf4e0f747 update tests 1aa0a9468 use shm to speed up tests 4dfe84106 wip allow raises-exception 59f3dd61c fix super() call 203a29e02 fix script fe812fb70 fix syntax 997895683 Add exiting note and test examples first 551125fa8 cleanup 9f80f886e cleanup 66cbaf1e8 remove extraneous call 523fe5cff allow for known error to be logged ae838bba9 fix logerrorhandler 14412aba7 lint 891107feb cleanup 426088f67 docstring f3244832e comments 3cc8a383e reuse the logerrorhandler fbd845d5e fix ordering 9e25e995b add more error handling 67439e15d remove console log 960dbe398 fix example error handling and update app example c7d5f49e4 remove extraneous trait 945c8856f Actually fix the broken tests this time. 77243da8c Fix a few more kernel test issues. 6fc177596 Small typing fix f8409edfb Fix more test typing errors. f29214f64 Merge pull request #6409 from ian-r-rose/more-granular-completion 022489d7c Fix a number of places in the tests where we use invalid kernel message types. b59470af3 Allow text-changed to ignore subset match change guard. cb296ddf3 Convert cell widget tests to jest syntax. 47111a7dc In cell execution, await the returned promise. 05cb00398 Add test for undo/redo of completions, checking editor cursor position. 6b7e820a7 Check editor cursor position in completer tests. b87e4bbcc Update tests. 2b0267182 Simplify cell prompt clearing. 3dd5882a2 Make output area kernel types more precise. 54a48f910 Tweak test so that it failed before the PR, passes after, to make sure we are testing the fix. 815a02879 Add test for cell prompt during execution. dd6781c7b Add documentation for message typing. ae750f8f2 Fix test typo. b893333c0 Fix test compilation error and history message typing. 1eba0ddd1 Only reset the cell prompt if the current execution was canceled. d88a6712a Convert some cell and outputarea functions to async/await. e33d477c1 Make kernel message typing much more precise. d90830ba1 use bind 33cb675a0 use debouncer d68c131cf remove value changed signal 42c32c115 Merge pull request #6407 from saulshanabrook/cp-hover a243d5ccc Allow codemirror to conflate diffs more easily. 0326f9c9d Compute the text diff upon completion rather than replacing the whole text field. cea511b2b Make selected command pallete darker on hover 77a940e09 Merge pull request #6406 from jasongrout/filebrowser-narrow 5dae61604 Merge pull request #6398 from jasongrout/upgrade 1a0ed72e7 Move @types/react dependency from ^ back to ~ semver range. 3b7dd9a4b Formatting changes. 4d1eebae7 Merge pull request #6399 from ian-r-rose/connection-lost-token 3215508a0 Hide the Last Modified column on a narrow filebrowser. 0ec21bbde Fix minor test errors from the upgrades. 25070610b Refresh yarn.lock one more time. 7b9b2266f Update webpack and testing packages like karma, mocha, etc. 18465c167 Fix typing ambiguities in buildutils. d7f95531f Update package.json for the new linting style. 6716a0814 Clear pending on directory not found error. bff8589cd Update moment, handlebars, commander, inquirer, etc. 1f9b34e82 Address comments. b02a9e003 Update a few more dependencies, like es6-promise, codemirror, etc. 8a86ca9c1 Add docstring. 39ce4e1d2 More reliably check for directory-not-found errors. 600d3fbd0 Void promise. 7e2f33b0b Move router token and interfaces into application tokens. 714d73113 Listen to the polling service managers for connection failures. 7e79346ec Add new IConnectionLost token to handle a lost connection to the server. 12e261fc4 Begin adding connection failure signals to the polling service managers. 7fb34cdb1 Merge pull request #6401 from afshin/poll-when-fix 7fcf42f41 Grammar mistake and docs build. 9f465a87d Disambiguate schedule and defer. 34e368c88 Add buildutils readme. 4becf3be5 Fix poll tests. 501d3b885 Add node typings to coreutils. Defer poll start. 18dcebfd1 Fix tests to use `auto` instead of `when`. 58550a8a2 Upgrade xterm 4030c4629 Updated yarn.lock e3b2a7eca Upgrade @types packages. 2f1456fbe A few more upgrades to fs-extra, husky, etc. 73a0eb921 Use same cancel signature. d97e3b56a Manually start services polls when ready. 7e6c7dc3a Add `auto` to Poll.IOptions and remove `when` concept altogether from Poll. 52694a1ef Update a number of dependencies to the current major version. 06e6dc5a9 Typo. df6228712 Merge pull request #6270 from yuvipanda/emit-open f43c740d8 Merge pull request #6060 from Madhu94/abcwidgetfactory-clone-method b686f4a16 cleanup ef71f2689 Merge pull request #6391 from blink1073/terminal-copy-paste 08a980822 simplify logic 2834c1194 Merge pull request #6345 from afshin/clean-coreutils b58d38161 trim memory usage in examples tests c6b1ac237 Fix import 3132d8509 update docs 456549f75 integrity 1bfae50d2 Use Cmd+C/Cmd+V always on macOS 901efa0d5 Add smart copy/paste and update docs 2bb58566a Update state database interface from `master`. ae42eea01 Merge branch 'master' into clean-coreutils ce4c47a99 Merge pull request #6388 from jasongrout/yarn-refresh 7391a88ea Merge pull request #6334 from vidartf/interfaces 33d87c1d8 Fix test compiling. fba791e73 Fix blueprint adapter typing error. ff7509169 Fix codemirror typing issues. 9ddcc048c Refresh yarn.lock. 8e030e09d Merge branch 'master' into interfaces 9a70889bb Revert from internal /lib/X imports 5cec89850 Remove superfluous async. 1cee0d765 Update document search close logic to dispose debouncer, make sure onClose is called when escape key is pressed. e74bba85a Use Debouncer in document search. f2a3f45e0 Use Debouncer in LabShell. 2aa927f1b Catch recover invocation rejection in splash screen because it calls Throttler#stop. f3424fdc8 Update poll tests to reflect when promise behavior change. 98b948705 Respect poll interval after poll's `when` promise resolves. c37dff35b Update doc strings. bd2ca9335 Add rate limiter stop tests. 5b14fbf09 Fix RateLimiter#stop(). a184cbd45 Update rate limiter tests. f3683a798 Test debouncing and throttling. 97adb2f7f Simplify poll tests now that Poll#schedule is public. 3732d0269 Merge pull request #6383 from manuzhang/fix_scroll 019a405ec Fix scrolling down running sessions 5bc504109 Support passing in NEVER to sleep function. 5007c3ef3 Add support for returning a promise that always resolves or rejects when the factory does. 7c0535210 Merge pull request #6200 from jtpio/toggle-ext-manager e6dbb80ed Update doc strings and use RateLimiter#stop() in constructor. be985f077 Update tests. 6f469ae43 Update apputils. 6f250660c Change Regulator to RateLimiter and export Debouncer, Throttler, and RateLimiter (abstract class). cdc37224c Make Poll#schedule public so polls can be composed. 288a3ac10 Add a rate limiter interface. 594076f2e Merge pull request #6338 from blink1073/should-include 4e0d10a8f spelling and integrity f86b43c35 remove extra config 3036c8af1 update docs and formatting 3db4f3cfd clean up logic about what should be included 447602508 prettier cc5f6ad6a Add metadata for core mode packages fd4e23b60 Merge pull request #6372 from blink1073/check-app-dir 93b84267f Update debounce test. 31d0486ea Throttle splash screen recover and debounce workspace saving. 015285beb Switch back to a Poll sub-class to support both `throttle()` and `debounce()`. d65e5e3bc Make `NEVER` and `IMMEDIATE` Poll class statics. c2ac6b2c0 add the build handlers regardless, for testing fc81a1412 Merge pull request #6375 from mofeing/fix-missing-merge-cells e16a767c1 Add command to context menu 19352258f Fix file header. 2a8dcf4b3 Test debounce function. 4090d91d6 Fix debounce function to always return a viable promise. 5bb7889c2 update docs 766f74254 Add an error handler and cleanup eda0d6e88 Update state database docstrings. 9570ca9a2 Resove the debounce function with the same return type as the function being debounced. ef5c19eb6 Create standalone debounce() function. 4dfb2a186 clean up core mode handling for end user 5b3abc6f8 update JUPYTERLAB_DIR docs 29e0abea1 Clean up handling of launch assets b04ce22a4 Merge pull request #6361 from yuvipanda/cell-type-label 537a13da3 Use better source map for filebrowser example. b0816dd34 Make sure terminal ready rejection is caught at least once. 197a0f899 Update poll tests to adhere to new types without modifying their logic. fd68181f2 Allow IPoll.Phase to be extended with additional tick types. aa79d265d Add doc strings and export `Debouncer`. 49e4c8b07 Merge pull request #6364 from fcollonval/6363-fix-session-not-deleted 200b3bbd6 Delete session from Set on terminated 88cbc53a8 Merge pull request #6340 from blink1073/fix-output-example a6db7963f Add label for the default notebook toolbar 1b7b5649a Merge pull request #6359 from yuvipanda/xterm-screenreader 6a115b4c7 terminal: Make screenReaderMode an option on ITerminal.IOptions cdaeb9ec4 Turn on accessibility in xterm.js 7d37ce3bb rename cli -> usage b3218504e add docstrings 223c63ed3 Merge pull request #6356 from saulshanabrook/collapsed 8e8ce16d2 fix tests and implement code changes to skip collapsed cells 2fc07f6ae Remove superfluous return. 50a6c3949 Merge branch 'master' into clean-coreutils d64bf6231 Use debounce function for saving IStateDB; remove bespoke debouncing logic. 6a29b562f Add `debounce()` function. 5a846eee2 test no-wrapping e6f2a6d33 test selecting skips collapsed cells b58e1ddce Merge pull request #6343 from rahulpshah/feature/JP-6199--use-json5-instead-of-comment-json 468801e4e Fix missing export of IThemeManager token 8705749b2 Remove lib/editor submodule import 4b19bde93 Refactor notebook tokens 88f5dcd17 Refactor coreutils token d09109cc2 Refactor mainmenu token b5571de35 Token refactor ThemeManager 7410ceb41 IRenderMimeRegistry typing 559fca085 Simple token refactors ea62d44f4 Docstring cleanup 7883e35d0 Fix setting registry test build. 6e610f050 Fix layout restorer tests. e9f7c255e Fix state database tests. b9f142dc3 Merge pull request #6350 from aschlaep/remove-find-and-replace-menuitem dcda9284d Merge pull request #6246 from jasongrout/autorestart cc21211a1 clean up test_examples a7d980384 ignore the examples folder 8ea8e925b Revert shutdown behavior when kernel is dead, and change documentation to match existing behavior. 7ec6378e0 Add more py.test config 0743bb258 Delete TODO notes about restarts timing out. 2884cf51e Fix broken clientsession tests. bcb921023 Integrity fix. 3e20b1471 Handle promises with a void. bab801793 Throw error when shutting down a dead kernel, like its docs claim. f5f7f5cef Clean up tests, stop skipping a few that work again. a044caefa ikernel tests pass now. 8885ecd0b Catch the kernel status dead rejection so we don’t have an unhandled rejection. 86176e682 Merge pull request #6349 from gnestor/issue-451 e770060d1 Skipped comm tests now pass! 130d44ddf Skipped console test now passes! a50a25eaa Skipped future test now passes! 549e7c97d Clean up kernel code (no functionality changes). 6d1865a0b Schedule sending pending kernel messages for the initial ready promise as well. 08474e98d Handle the ‘connected’ kernel status differently. 76b1ebc4d Send pending kernel messages via the kernel ready promise. 0e188bb47 remove codemirror find and replace, edit menu findReplacers b1da94fa2 State database options should have a default. 5c0d82680 Simplify instantiation of state database. 950218bdd lint and py3.5 compat 35d23c8be remove unused import abbb12272 integrity 0a074490e Clean up base_url handling 5ca21718e integrity ac103c4c5 More state database refactoring. a2aed3b25 wip cleanup and allow for base_url 975954ce4 clean up top level examples a74a80510 Add test for app example fbfabb378 Run all but the example app b23d98c98 wip add automated tests for examples d5ea1db48 update deps 5ef71906c cleanup 014df3418 formatting be2d0e00f clean up output example and add to tests 5cd23e65c More tests that are actually fine. 39599db06 Toolbar tests are passing c3c9d2157 Run jlpm at root 58008418e Remove comment-json from dev_mode 893aaaed5 json5 to dev_mode 5477e6bbc Use json5 and update package.json 4b9a41827 When restarting, handle a requestKernelInfo that rejects. 2f63f65ac Be more careful about future done promises being wrapped up when clearing kernel state. 1d40ecd37 rewrite restartKernel function to be async/await d4b4a8267 Rewrite dialog test utilities with optional arguments and async/await. edce02555 Add (experimental) to the ext manager cmd 0f3b24fd5 For CI testing, do not bail on first error. 7d31d6a1c Fix console error. b9f2f15a6 WIP: Skip tests that aren’t working b236b4541 test describe functions should never be async (and should not return anything) 365b77ef1 When kernel is done initializing, make sure to set the isReady state to true along with resolving the promise. 8cac49d39 More work in progress to simplify state management on restart. 463af7a3b Pop up a dialog on autorestarts. 579c7af9c Make sure the notebook language update is not obsolete by the time we make it. 32339656e Make sure the console shows a new banner when restarting. 290c4db00 Fix kernel status indicator to only show busy when it is actually busy. 78abc4420 Do not kill the websocket connection on kernel restart. 6ebe08b0c In a kernel restart for a console, use the existing kernel info for the banner. 51c3ad924 Make a new ‘autorestarting’ kernel status for restarts we didn’t cause. 0b1a40d82 Enable ext manager cmd if builder is available 3ad004a43 Create StateDB.Connector class, remove namespace and windowName. 3670ef153 Merge pull request #5850 from saulshanabrook/print-notebook 208aa833d Get both widget from main app for printing 77cb8dae0 Remove `contextMenuWidget` 845084e81 Update doc strings. dfcbd4c65 Remove maxLength test. 8a5a4f56f Merge pull request #6339 from blink1073/terminal-zombies 7548bf043 [WIP] State database refactor. 311849778 Handle initial state database transformation promises. d44f2a183 [WIP] make state database use in-memory storage instead of local storage. fbd1f03ae Remove `window` from activity monitor. 609799bfa Remove unused import a406241f1 Linting fix ca9890d94 Only create server settings once for printing d22570441 Merge branch 'master' into print-notebook 469696d81 import dependent styles 90eb7a7d2 Merge pull request #6344 from rahulpshah/feature/JP-6280-terminal-appear-twice 7a6356480 Merge pull request #6335 from ian-r-rose/default-cell-type 7ac3e23b3 cleanup term example df436755b cleanup 215aa21cf Clean up terminal shutdown behavior and tests 701265f71 Remove extra submenu 2839ef525 Merge pull request #1 from jupyterlab/master d3bb7c9ac Fix comment. 4329afee8 Fix test. 9761c3b75 Fix up tests around whether new markdown cells should be rendered. b3e680ee8 Fix tests expecting a code cell. 6b155e606 Handle disconnect messages from the terminal 592b17e53 move versioning to the end f233cb50f Merge pull request #6305 from ian-r-rose/filebrowser-poll d866edd06 Add geojson support to json-extension 6746f7d55 Void unhandled promise. e55aba60e Make the notebook widget responsible for adding new cells. 3b16fda70 Default new empty markdown cells to unrendered. e965f2079 Handle the case where the notebook widget has no model. 4e1f82c90 Convert creation of new code cell to that of default cell type. 44c64883c Add createCell function to notebook cell factory so different cell types may be programmatically generated. 3427d2f91 Add default cell type to notebook options. f67974bc5 lint 31462d9f6 change order ad26408da clean up script 74b886250 remove unsupported cmd c431c0e79 move the core mode update to after publishing JS packages b7dfd1d5c fix version 5211238d7 Merge pull request #6327 from fcollonval/6326-input-dialog a68996dea fix bumpversion syntax 13369b0d2 Correct error wrapped list has no value 3762f4b64 Add whitespace 103b979eb Add a --force flag to the version bumpers cd5873d81 Correction following review 573dc0a7e Merge pull request #6329 from fcollonval/contributing-patch-1 56493b8e7 Add input dialogs 009fa879f Correct Jest cli argument names 527b88340 Add a patch release guard 89db0e93d Update PR template 329a1ac17 cleanup 71fe80b6c return to original version.py with a comment 2744daa33 more parsing cleanup 17f06dc47 fix _version.py 09e0fba70 clean up 1ac7cf562 fix formatting of version info 23bc2fc00 handle the dev mode version ourselves ccdf9133c separate versioning from publishing d9671ccb9 cleanup 272a81940 cleanup d4ecf8bc4 remove unnecessary step 5b681d871 finish cleanup and docs 20b5101f9 Add a command to bump JS major release 62a61db66 fix indexof eeb93bdf1 Add the publish step to the release and clean up lerna handling 13430b017 cleanup 5c712fad2 wip 4483394f2 wip d095f9239 wip 1d40a32bb wip 50dc83451 wip 82872327e wip 0cf39f90d wip 5f71e97da fix spelling ac2ab754f cleanup 5110896a6 cleanup 3f4ebe59d fix version lookup 5f682a6be fix release names 39936da70 fix unused import 4c3aff7bf fix syntax 34d2e09f1 Clean up version handling 01f9e46c7 Add git config d0203c9ec Handle git state 95837b154 no need for comfirmation 3d8b67f64 explicitly install bump2version 06574c342 add a missing flag ae5cc16ce do not create tags on prerelease and run version check first 2ab3555eb try canary 691b6cff7 write the version to package.json using the parsed version 2bd7bdcab wip 09f7a50fe fix current_version a251b82ff Use specifier directly a0810fe04 clean up and use bumpversion for package.json a88036ce6 fix script 3dc057a35 Ignore eggs directory 93ec5440d update comment 96d700e0a update notes and use verbose mode for dry run c1b14c598 cleanup ec7090f18 integrity 6a57393ec Streamline versioning with bumpversion 2c57346d4 Merge pull request #6297 from bollwyvl/more-yarn-lock-stuff 42ee33382 Merge pull request #6325 from jtpio/rename-file 27c6260df Merge pull request #6321 from ed1d1a8d/upgrade-codemirror 54e1198c3 Fix "Rename CSV File" 21c37102f Upgrade CodeMirror from 5.42.0 to 5.46.0 52b871d72 Merge pull request #6311 from blink1073/downloads-badge ad5ed01f5 Merge pull request #6314 from SylvainCorlay/nbconvert-css 1593668cd Since we can't use traditional event handlers in the print iframe when JS is blocked, we consider it safe to discard of the hidden iframe once event handling has returned to the main content window. 8703549fa Delete iframe after printing 8c7ea4cb4 Try waiting till done printing to clean up iframe 3bfc916d8 Change to use server connection instead of fetch 2f9f67208 Fix apputils print shortcut 959268f2b Move printing to apputils 3c9aaddc2 Merge origin/master into print-notebook 99c3375c3 Add JupyterLab CSS bundler 7427823ef Add clone() method do ABCWidgetFactory 4fac65eed Add a downloads/month badge from pypi 019cf173d Merge pull request #6308 from ccropper/alpha3-markdown ad2b92e97 fixes code markdown background without regressing code in list background issue 4d5b279e4 Merge pull request #6307 from jeanruggiero/jr-test ccf3c50c9 Updated documentation to indicate that remove:package will delete all of the package files. be963b571 fixes issue #6296 markdown 0cf97c8db Updated documentation to explain that remove:package does remove files added by addsibling. ac048a640 Updated remove-package.ts to remove the line that allows absolute paths for packages and added an error message for the case where the user supplies an absolute path. See issue #5803. be4cc1a0d Use poll refresh, fix up test. 99faafaf6 Don't await poll.refresh in filebrowser model refresh, as it cancels previous invocations of refresh, breaking chained directory changes. 627b1db1f Add explanatory note to poll refresh function. e3ee84429 Remove logic around MIN_REFRESH interval. 8c72b122d Merge pull request #6306 from ian-r-rose/tab-bar-icon-size 88e20b03f Merge pull request #6304 from ian-r-rose/carriage-return-perf 07d7b4de2 Get rid of `scheduleUpdate`, retain minimum refresh time. 1679819dd Set tab bar icon background size so SVGs of other sizes may be used. e7774e961 Remove modelDB from output area options. 8a938264e Use new Poll class for filebrowser contents polling. 94d9a3e9c Move utility functions that don't need to be class members into a private namespace. b899ab069 Make sure the cached value of `_lastStream` reflects the removed characters so we don't have to remove them over and over again. 2de356fc2 Remove dead code from the Google RTC days. 84d6ecaff Merge pull request #6301 from aschlaep/no-default-searchproviders 18d8c1411 remove notion of default search providers 0e1e34e02 Merge pull request #6299 from jasongrout/logout-menu-name fe59e858f Merge pull request #6294 from domoritz/update-vg-5 a6466065d Merge pull request #6282 from aschlaep/remove-searchprovider-deregister 8d8cbb203 Replace shutdown with shut down a few more places where it was used as a verb. 75b9f3ce5 Add log out to the command palette next to shut down. 04b76e710 When used as a verb, shut down and log out are two words. fecd1f20e Merge pull request #6087 from Madhu94/add-logout-button 1b70710b2 dedupe docstring f7cb0d903 also commit the deduplicated yarn.lock 686b144d4 experiment with pre-copying yarn.lock 11a105955 Update Vega and Vega-Lite 7eece9ecb add missing docstrings 98c82e6d2 Merge pull request #6288 from fcollonval/6274-nb-update-config 760463c1d Merge pull request #6287 from fcollonval/6284-console-fileeditor 82cea068d Merge pull request #6285 from fcollonval/5241-terminal-shutdown 96c5add98 Change 'Shut down confirmation' to 'Shutdown confirmation' 02743419a Merge pull request #6292 from afshin/tooltip-flicker 628c118a9 Prevent tooltip flicker in Safari. 962e75920 Add shutdown on close capability for terminals 610a00fe3 Common function for opening console on notebook f881c5b10 Refractor updating notebook settings for opened widgets 050eb7d58 Common behavior for console creation on file editor 7240a264a update dependencies 2fc1cddcb apply better searchable widget accounting when registering and deregistering search providers 92a0b2ac0 Remove deregister, rename register and return disposable 25d8709e7 Merge pull request #6275 from fcollonval/kernel-shutdown 506e81588 Merge pull request #6264 from ian-r-rose/fix-pdf-scroll-firefox 2a6235282 Correction following review 0e0b82b94 Merge pull request #6265 from kristinauko/fix6145 0af6067a7 Merge pull request #6276 from wonsjb/ISSUE-6272 3779f3d5d Restrain to notebook b18c7c0ed Fix typo. c6b7487f6 Issue-6272 Allow passing "-" as a file to jupyter workspaces import, to read from stdin 8d0bf96b7 Working version for notebook c7ad22904 WIP Shutdown kernel with widget 94c3bf884 Provide a signal for opening items from a DirListing ba698ff57 Add a Logout command to file menu and rename Quit to Shutdown 2b7babd7b primary output of a command changed to output with print() (instead of logging) ccc943554 Get rid of fragment before hiding PDF on firefox in order to retain scroll position in the case where there was a fragment. bbd6be175 For some reason this allows Firefox to re-find its scroll position upon unhiding the PDF widget. I have no idea why, but this check is relatively harmless and fixes a regression. 392dba939 Merge pull request #6256 from aschlaep/initial-search-text e0a1d0ccf Merge pull request #6247 from jasongrout/prtemplate 11d2e8f2a Merge pull request #6237 from aschlaep/search-shortcut-selector-scoping e3bfff36a Merge pull request #6234 from afshin/issue-6210 d6cde229d Merge pull request #6262 from ohrely/md aae4076d7 New markdown reference plays nicely with iframes b5fd981d8 Merge pull request #6258 from bsyouness/filename 0892fc51f Merge pull request #6261 from Tom-Nudell/activeline-dark fa9fca4d4 Merge pull request #6259 from kristinauko/fixcommandpalettecolour 0c0e78a5c Set the CodeMirror-activeline-background and CodeMirror-gutter background-color to jp-layout-color This resolves the CodeMirror ActiveLine highlight issue from issue #6053 bc29228b4 set font color according to theme in text matching command palette 678c37727 added file path to dialog 2dcdd45fe Merge pull request #6255 from ian-r-rose/less-aggressive-pdf-updates-2 10ac1a7d9 Merge pull request #6241 from aschlaep/fix-documentsearch-refocus f5668f5fd add getInitialText to interface d99d5f4c9 Fix z-indices for iframe drag hack so invisible div takes priority. c73258741 Fix up CSS for PDF in notebook outputs. 3d0dec7de Put object tag in iframe, cleanup. 4d9719096 Remove “here” 6fcd7f1d7 Document that generally an issue should be opened before a PR. bccad6367 Give the PDF renderer a lower display priority. 7730528ae Don't rerender the pdf if the base64 encoded contents have not changed. The string comparison may be expensive, but it is less expensive than rerendering after every reveal, which is the current behavior. 1cc82fd1f revert changes to test notebook e7cd79001 add documentsearch commands to the notebook example 90d2025ca move lab shell css class application to its own plugin f40af6cb6 Merge pull request #5775 from vidartf/yarn-opt 1beddfa03 Make language asking for screenshots simpler and more consistent. f5e475d69 Fix typo b2e5fefcc Update initial greeting and instructions for PR template. af5bc97cf Move checklist items to formatted templated sections. 551596f50 Simplify PR template language even more. d3a62afd6 Use yarn-deduplicate b563c05e3 Simplify PR template. 7844502c2 Merge pull request #6219 from blink1073/upgrade-ts-jest 4c8c7f164 Use commonjs for services and coreutils 62207fdb4 update pipenv docs link 9013d380e use istanbul config 6ca41122a try adding babel config 13a854380 Merge pull request #6240 from saulshanabrook/app-dir-symlink 59934d887 Switch all uses of realpath to abspath. 340b5dce6 Take abspath of app directory e17dc44ea Remove extraneous argument to popd 5caeaf82d Don't take realpath of app dir cce45f0b2 Add new test for symlink app dir e8adb7ffb Make file browser shareable link be a simple `tree` URL. 555d84b41 Remove 'resolve-workspace` query parameter, redirect workspace dialog, and make resolution automatic. 6eadcdd1c Check that request is current when iterating through matched routes. Ignore duplicate URL navigation. 310a272a9 Add default shortcut for printing 055f59a2d Remove logging 80b3d5e92 Fix iframe usage by downloading URL seperately 3be993e14 Remove printd dep 58dbb5b65 Merge origin/master into print-notebook 5e415dc6f Add comments d4bfaceac Update babel config 3b5b55598 Merge pull request #6182 from richagadgil/patch-2 5ea83862a address lint errors 302044dc3 lint the request template da4e21c3d add babel preprocessor options 1ce9ace20 try karma-babel-preprocessor 09684ee22 fix re-focus on ctrl+f when search overlay is already open 60658deb0 shift selector scope to searchable class 4c264b78f Merge pull request #6236 from markellekelly/cssfix 89b00c40a Fixed documentation formatting issue 981520d14 Merge pull request #6221 from blink1073/nbformat-dialog b117452de Fix nbformat conversion dialog test. 3e1bc93a2 fix import 675bf46d8 add missing files c454c365e cleanup 498268e5b Use babel config in alltheplaces 4f7b8c96e Merge branch 'upgrade-ts-jest' of https://github.com/blink1073/jupyterlab into upgrade-ts-jest c4bcc0d81 Fix application tests fc1fbdc42 Add `?resolve-workspace` to the shareable link produced by the file browser. 62c8d9a9d Merge branch 'nbformat-dialog' of https://github.com/blink1073/jupyterlab into nbformat-dialog 8f9f02ec6 clean up tests 735212e8c Don’t pretend the sample notebook was converted from format version 1. 49990153a Use template strings even more in notebook format change dialog. cf1063590 Merge pull request #6227 from jasongrout/paths2 d67e8dd6c Lint fixes 35b15d7e1 buildutils and test tsconfig inherit from base config again 559b69e3e Merge branch 'master' into pr/blink1073/6219 8bdf7a79d Note that server directories are for information only. 7635934ef Merge pull request #6063 from vatlab/inject_metadata 9c338a12d Merge pull request #6224 from jasongrout/es2017 3b0c6e622 Merge pull request #5723 from vidartf/dev-build-conf aa4a095bf Fix testutils b47d5d558 Add missing space f3951e00b use string interpolation 92b73faac use commonjs for buildutils 360ddef6b fix buildutils ffc37cc64 Update Typescript target to es2017 8eb604aaf fix uses of commonjs imports 1c5343389 Merge pull request #6220 from blink1073/windows-path-length 3c27a83a1 ignore promise result 37294c99e Remove debug statement f9cb4d08d Add a dialog for an nbformat conversion 6582543fe Add note for Windows users about path length dca746bf1 Merge pull request #6197 from jasongrout/prettier17 91a8864f0 Switch to esnext imports 56f31fd19 Optimize how metadata are copied 427552d10 Revert "Optimize how metadata are copied" 5d3dd9c1a Revert "Optimize how metadata are copied" e75b7c9cd Optimize how metadata are copied 0273b4c7d Optimize how metadata are copied b83685efd Optimize how metadata are copied 9d12de3f8 Merge branch 'master' into inject_metadata 347f1bb32 Merge pull request #6012 from bollwyvl/lazy-load-xterm-extension-promise e27794a88 Merge pull request #6052 from gnestor/issue-5979 7559fc328 Remove unused findTab 8ccd492f7 Fix no-floating-promises d9f1d1290 Make prettier 92c297bc5 Rename mainmenu commands 84f8ccfc9 Move commands in schema files c6cfc56cd remove unused setSession from terminal a865003d5 Merge remote-tracking branch 'upstream/master' into lazy-load-xterm-extension-promise 4dd47c5ff Add comment 66ecfa4fc Add close to tab context menu ace290f42 Clean up 878754ace Update context menu tab logic in application extension 6603a0505 Clean up 7997cea62 Remove dependency on labShell in addCommands 1592ef3e5 Remove closeAllFiles command 1137896df Remove dependency on docManger in application-extension 7d31626d9 Change selector for closeOtherTabs and closeRightTabs to all tabs ac4213af0 Move generic tab commands from docmanager to application 91af807f8 Merge pull request #6211 from bollwyvl/fix-settings-picker f171f3d92 make settings picker flex for #5874 55a1c7d1e terminal: address compile issues after merge, some review comments, move things to constants so widget can be loaded ac5a93249 attempt to resolve merge conflicts 5031e87ea Remove unused hide and show commands 2d006f56e Merge pull request #6194 from ian-r-rose/error-on-build-problem c80d52249 Merge pull request #6201 from parente/vuln-reporting 1412007a4 Add mailto: to email link. 8dda5f57a Add vulnerability reporting info b81bcd86e Remove unnecessary var, use plugin.id instead c82da05bf Add mainmenu to ext manager dependencies 1e64edb88 Rename Toggle to Enable for the ext manager cmd 785b6ea7b Add extensionmanager:toggle to the main menu 306d50aa6 Add extensionmanager:toggle to the command palette 33057bfba Merge pull request #6198 from jasongrout/changeloga3 75189d16a Add a note about at least one hint for upgrading extensions for 1.0.0a3. b265bec34 Separate out changes in 1.0a1 and changes in 1.0a3. f418f2608 Updates changelog for PRs merged in 1.0a2 or 1.0a3 57d218a49 Fix new lint errors from prettier and tslint. ad7fd295c Upgrade prettier to 1.17 cf43cded2 1.0.0a3 44cf7fae9 Prerelease version 896452ec7 Make version and publish package.json scripts more consistent 55b3814b6 Make all package build steps use tsc -b 7834113bf htmlviewer-extension cleaned before packing. 25152cd7c Prerelease version ed465728b Delete gitHead keys in package.json. 2f6f369df 1.0.0a2 release build 1409b1341 Rename the top-level publish command to publish:all to not confuse lerna. 528f5c252 New gitHead package.json entries. 1d16c024d Prerelease version a103b1bd2 Teach lerna about the jupyterlab test mock package. cd40f1c76 Don't prompt for different version if dependencies fail to install in `jupyter lab build`. be57290e6 If there is an install or build error on `jupyter lab build`, produce an error message and code to the terminal. 78e837aec Update release process to split version bumping, git push, and npm publishing. f4b968681 Merge pull request #6193 from jasongrout/terser c0d10664b Merge pull request #6192 from afshin/api-requests 604b7af4c Convert from uglifyjs to terser for js minification. 6de007b09 Fix incorrectly cached pending in async function. 3498bc355 integrity update 2d428c2cd Publish with 'next' tag fde4625d8 Merge pull request #6059 from ian-r-rose/restart-run-all-for-file b235b6cdd Use the same reference to the console session. cd0c5968f Fix restart and run all for text files with a code console. 4d0607e52 Merge pull request #6191 from ian-r-rose/unpin-yet-again 5d9943a44 Add note about expected console errors so we don’t think the tests are problematic. 51f5eaae7 Fix phosphor signal complaints. ca6b048c0 Don't try to shutdown the same session twice. ab87466ca Allow notebook to upgrade, but keep tornado < 6. d786a4a04 Merge pull request #6186 from afshin/api-requests 3a5104438 Run new prettier. 42e3f4d33 Simplify schedule and fix tests. f947ad1d0 Update tests to for Poll#schedule(). 94b8f4412 Update Poll#schedule() to be asynchronous, accept partial state data, and to automatically handle ready state. d7503e07f Merge pull request #6190 from jasongrout/updates3 da461625b Merge pull request #6189 from jasongrout/updates2 44bea3951 Update formatting with new prettier version. 91587fd4d yarn.lock deduping ea57559e0 Update the rest of the root dependencies, like prettier, eslint, yarn, etc. 8c19c9359 Update yarn and lerna dependencies 61e978fc4 Remove printd 35d088f2f yarn.lock updates 500efd5f6 Access raw-loaded md files as an es6 module. 0a9cfd62e More yarn.lock deduplication. 0873f81b7 Fix csv viewer tests for the newest version of raw-loader. e4c9bb72e More yarn.lock updates. d33c57927 Ignore the new typescript incremental build cache files. 63c9f300f Update webpack and webpack plugins. 9760799d9 Merge pull request #6188 from jasongrout/updates f05372cd0 Run yarn-deduplicate on the yarn.lock. 73ec605a5 Update to typescript 3.4.3 0a2611921 Sort tsconfigbase options e56b0b8d3 Import from top-level packages in tests. b35aa824d Fix jest config 35d9db7af Update jest to 24.7.1 58a301a86 Update yarn to 1.15.2 f7f517974 Merge pull request #6181 from jupyterlab/jasongrout-patch-2 f99c21687 Merge pull request #6159 from aschlaep/search-and-replace 786cd3677 Update pull_request_template.md with checklist 6de695d43 Additional documentation 7558addc8 Update documentation, fixed null types, updated async return values bd5468de7 Add a time zone conversion link to the dev meeting time e44293081 Upgrade to latest printd and remove firefox workaround 730333fbf Merge pull request #6141 from afshin/api-requests b47481ff6 Update Poll#schedule docstring. 2f203d1a2 Revert session/terminal manager tests that now don’t change. fa961f3ca Merge pull request #6153 from AlbertHilb/gutterBG a8f58a66e Merge pull request #25 from jasongrout/polling3 4f80f7398 Update terminal manager to be consistent with kernel/session manager async logic. 97511737c Merge pull request #24 from jasongrout/polling2 28d55ba0e Make session manager class consistent with the kernel manager changes. 520ba6627 Clean up some of the kernel manager async and request logic. f33db4b8b fix variable spelling, improve async functions 4bae4dbcd Clean up Poll#schedule() to make it easier to read and reason about. 5df0d050c Make Poll#tick test more robust. 240876a25 Add test to verify `tick` promise resolves after every `ticked` signal and before the next `ticked` signal in lock-step. dabe07e0c IPoll.Tick => IPoll.State acfaa466b Update documentation to be more clear to me. 52dc3d06f Address review suggestions. acd500266 Don't wait for pending promise to resolve before emitting ticked signal. 790a54075 Clean up and fix tests. c7863034f Implement ‘decorrelated jitter’ as our backoff strategy. 890bc2f41 Update the jitter to return a uniformly random value between base +- (base*jitter), capped by the min and max values. db18372a2 Clean up. 6e9bc509f Update TerminalManager. 3e1840051 Fix SessionManager and its tests. 8f4e7c67b Refactor `KernelManager` and its tests to pass. be58ebcda Update polling API, make `ready` protected. Update tests. 731ff4b14 Fix disposed logic regression. 528c5ad62 Add Poll#ready promise instead of checking manually in each method. ffe6b9fed Poll#_execute() does not need to have the outstanding promise passed into it. 5eaa49fd0 Poll#schedule() does not need to have the outstanding promise passed into it. 2ad1e347e Polling should start as soon as `when` promise has resolved. 11b93967a Clean up. e780d604a Update poll tests. d347a52c8 Use poll instead of setInterval CodeMirrEditor. ba3b1b4a7 IPoll.Standby => Poll.Standby 5f7d21685 Update handling of frequency and standby. d24d1f7ec Update docstrings. 63d5f3a52 Clean up state initialization. f650bcc63 Check that error exists before trying to print it in tests. 323513731 Define IPoll.Factory, make `execute` and `schedule` protected. 20912a62d Update disposed handling and check for disposed status in override. f41d8f670 Simplify poll frequency API. 366285fc3 Add generic parameter defaults for IPoll. 6b7d95e70 Fix dangling promises. 8fa2de9f3 Remove concept of `readonly` and use a separate IPoll interface modeled on Signal/ISignal. f03b410d9 Handle tick failures in public methods. 07383d759 Check if disposed by checking current phase. 9eeafb4fc Add disposed phase. c55b1e0c1 Fix refresh behavior and tests in services. 2a56368b5 Fix client uses of Poll#refresh() to respect new semantics. c73770a03 Clean up. 599133552 Respect `readonly` flag in refresh/start/stop. 866f49758 Update Poll#dispose() test. 25eb20a2a Check errors after normalizing in frequency function. 36ab86115 Update poll tests. 618a1bf4c Use standby `when-hidden` logic. d71336bee Remove inaccurate docstrong. 5e945ef6a Audit private variables and methods. 987fc3e2f Update docstrings. 9f8c0e125 Clean up refresh/start/stop semantics and implementation. f28f6de35 this._setup => this._frequency 2f338d53f Update `jitter` semantics. 88af58582 Update `jitter` parameter to be a boolean | number and set its defaults to 0 and 0.25 for false and true. Default to 0. f50dc72d1 Add `readonly` tests. 4c43ea74e Make `interval`, `jitter`, `min`, and `max` (the polling frequency parameters) editable. 066ccdc62 Remove artifacts from pre-InstanceTracker dialog tracking. 40c444492 Re-remove .travis.yml a2309548d Add `readonly` functionality to polls. 816f0dfc0 Re-enable all dialog tests except one that still fails. 981960634 Partly re-enables dialog tests. 956268f71 Add a tracker for all dialogs. bc984efba Test acceptDialog (temp WIP) 029e41c65 Rename to Dialog.flush(). 308ea8737 Try Travis. c9373c2b9 Add Dialog.nuke (experimental) 837ee7f44 Use it.skip() 5636cbfb9 Make onActivateRequest test of code console synchronous. 95089387c After shutdown, entities ought to be disposed. 77eff053c Fix shutdown signal emission logic. d583b984a Update tests to use `standby='never'`. a6d1cdaae Parameterize `standby` of polls. 4f405f90b Handle situation where `document` is set to `null` by an environment. a24919355 Handle case where an environment may have set `document` to `null`. a63e44496 Update poll tests. 7cc81523b Fix poll stop behavior. 8ef1871e6 Update poll tests. 07c6fea24 Update when-resolved, when-rejected to instantiated-resolved, instantiated-rejected. 1b0f40bee Update poll tests. 148082302 Add more poll tests. 0f0131366 Clean up poll API and handle waiting for `when` promise to resolve. b7065c5bb Add documentation notes that indicate poll ticks as little as it can. 6a437c170 Clean up poll dispose. d5ee4e395 Add poll start and stop methods. 76e4b5fce Simplify poll class, continued. 543f89a6f Simplify poll class. 582966c38 Use poll in status bar memory usage. 925860ddb Use variable name "poll" and "next" for PromiseDelegate instances coherently. efb14f6c0 #refresh() should return a promise. a8bb3a3c7 Update poll documentation. 9ec535117 Remove `Poll.Next` concept and simply resolve #next and #refresh() promises to the poll instance itself. Allows returned promises to be self-contained for following the chain. Emit ticks after promise resolution. 5b32d95b9 Synchronize poll state, ticks, and next promise resolutions. 37539941e More simplification and clean up of poll class. 8fb9dd336 Update polling API, simplify signals. Reveal more state. 7b5fe9d26 Change `schedule` to `origin`; it is clearer. 9b43abb02 #next can always return a call to schedule and rely on that function to return the outstanding promise. a3804767e Add initial poll test. 79dc3fb27 Audit disposed flag after every asynchronous action. Catch promise rejection in dispose method. 48d6747cd Since connected is always available, make it a public attribute instead of only passing it into the promise factory. fb40f463c Clean up poll class. c9250074f Remove `_ready` and `_isReady` and instead set _outstanding in the poll constructor. 3184488e2 Better document Poll#next. d40a63f36 More clean up and async in services. 7fd8b0369 Use poll refresh to trigger terminal manager refresh. c5dd25616 Add schedule from `standby` state. d0a827a1b Clean up. d66e05572 Re-schedule poll execution if document is hidden. 1ce6bec21 Emit signals only after the next poll promise is scheduled. 231f57657 Update poll chain logic. 5ab8a5e09 Add poll `tick` and `ticked`. 03bb52734 Change `payload` to `resolved` and add a `rejected` signal. 1d40e967d Add `payload` and `disposed` signals to the poll class. 7c127e36d Clean up poll class, make min/max public, change `poll` argument to `factory`, etc. 5b8651aa8 Add support for max poll interval. 008e89f66 Update doc strings. 576cd6843 Define Poll.Next type. 8867d0244 Update poll logic. b8cab09ed Update polling logic. e4768cdf8 Support poll refreshing. d30ac050f Always send XSRF token if available. Fixes 403 bug after reconnects. e982a8aa0 Log when poll reconnects. wobble => jitter 6dd081111 Add support for poll interval variance. 4ceaff4c5 Update shutdown logic. a012b4ab9 Add `when` promise to session and kernel managers. 4d225c8cd Update terminal manager. 3621f2bdd Add support for `when` promise in poll instantiation. 884c0adbd Update poll names. 89d632950 Use poll class in terminal manager. b554c1e23 Add optional name to poll for console output. 55c9163b0 Update polling logic: check if disposed after poll promise resolves or rejects. ecb33c6af Improve warning when poll is rejected. 4ce59a8c9 Update kernel manager to use poll class. 0972f6012 Document polling and fix logic. b5919f6d4 Add Poll class to automatically poll and exponentially back off of failing poll requests. 77d61b073 Update session manager to use async. 11c0d7d3a Clean up doc strings in running extension. 1220ab595 Remove `line()` function which is superfluous because of String.prototype.repeat. 17dbb5b0b Merge pull request #6173 from afshin/typeparam ed72e1337 Merge pull request #6082 from markellekelly/cssdoc 5cd24058d Use simple double-quotes so snippet can be copied and pasted. f9e741c23 Merge pull request #6168 from lresende/update-contributing-for-dev-mode e26431985 Use @typeparam` in docstrings for front end and connectors. 07da56593 Merge pull request #6172 from ian-r-rose/update-affiliation 0ea90303b Update my affiliation. 46e04d343 Merge pull request #6171 from afshin/node-null-check 1bd8d78b0 Merge pull request #5968 from jasongrout/save-with-options 9952cecae Make sure `node` exists when traversing up the DOM tree. 776f0275c Fix padding issue with the metadata editor control f1830f407 JSONEditor: only set/delete values that actually changed. a5ee27821 Fix typo bf3160671 Call super.dispose at the end of our dispose. c5ebab4f0 Add/remove handlers on attach messages instead of constructor. c31b311fd Merge pull request #5964 from gnestor/terminal-theme b8a5c84de Fix broken link in docs 8d2a5a651 Fix tests 1b1d72ba8 Clean up 1abbe45bc Allow users to select light, dark, and inherit terminal theme 6f11a7fcb Fix dark theme inconsistencies 3971033a0 Remove theme settings and commands from terminal-extension 6efb28f60 Update terminal theme when lab theme changes ccdbe25cb Use current theme for terminal theme e5d46d302 Add details about extension activation in dev-mode 6b3c87cab Merge pull request #5670 from gnestor/vdom-events cfa683ff1 Merge pull request #6029 from rahulpshah/feature/JP-6017-render-mkd-cells f5c05a5bf Integrity c4240cd6d Fixx null check b5b2527cf Fix default print popup on firefox 45d181b02 remove special case CSS inspector print rules 0c65a50d6 Fix import fe033cca0 Remove unused callback arg 3f93b5890 Handle all async functions 4cd02f0d9 Merge origin/master into print-notebook 46cbd4f19 properly apply tabindex magic to replace buttons e8ad4c9a0 add padding for readonly search box 3db933c77 clean up test logs 32022c811 add tabindex to replace elements, update css b0d8373c1 updated icons, tweaked spacing 48e33e5a9 remove highlight button on focus cb8265fcf search overlay UX updates 38f56f9b3 search and replace with temp UI, search as you type 85623d09b corrections to CSS documentation 79a332d51 Merge pull request #6155 from aschlaep/update-search-colors fdd406db6 Merge branch 'master' into update-search-colors c930c97a8 Merge pull request #6050 from gnestor/issue-6043 00d6c0cd6 Merge pull request #6026 from telamonian/universal-scrollbar-styling e29823a08 Turn off theme scrollbar styling by default e20c5bca5 Merge pull request #5920 from gnestor/issue-5269 db7729e8f Merge pull request #6114 from raybellwaves/patch-2 951b630a0 Tweak grammar d7a85300a Merge pull request #6094 from aschlaep/search-tab-index 2069ce542 Merge pull request #6126 from ian-r-rose/no-prompt-for-markdown 398dc8d0d Merge pull request #6154 from ian-r-rose/remove-accidentally-commited-notebook adce6e727 Merge pull request #6156 from ian-r-rose/remove-hooks ed964dd5a Remove out-of-date git hooks. 7bc0ff128 Unwrap a string class name. 6a4a91b15 removed some extra menu items 88a120eeb Merge branch 'master' of github.com:jupyter/jupyterlab into save-with-options 0f037219d update light theme color 36dfc3e5b Sync `collapsed` and `jupyter.outputs_hidden` metadata in the cell model 80ddce43b ObservableMap: only trigger a ‘remove’ signal if a value was actually removed. aeb3a60e6 Remove running person icon and CSS classes 9b4930ae9 Update running icon 6d89b1cc5 Provide vdom instance tracker 7ee14cc34 Split vdom-extension into separate packages 5369d8a6c Provide notebook context via INotebookTracker 7797ecf07 Decompose createRendermimePlugin 3d1df4d13 Use createRendermimePlugin to create plugin from widget 8770b8ca3 Move index.tsx to widget.tsx 660b9e6bf Convert vdom-extension from mimerender extension to regular extension a1fb954d6 Clean up 40e743788 Handle nonexistent session 3ed9ad732 Fix "Too many open files" error b8f5db576 Upgrade @nteract/transform-vdom b40a18317 Add support for event handlers to vdom-extension 844bbf058 Merge pull request #6117 from jupyterlab/jasongrout-patch-1 c05ef5a2e Merge pull request #6056 from alfsuse/master ed7e7ecf7 Change "the next-generation ... interface" to "a next-generation ... interface" df3a91c74 Merge pull request #6057 from tibdex/update-react 1a44c62ec Accidentally added this. c33ac7e8d Make CodeMirror editor gutter background the same color of the text background. Put line numbers in the center of the gutter. 65d78caa2 Merge pull request #6152 from ian-r-rose/linter-fix 7a8a42694 Valid JSON, update keyboard shortcut format. e0431cab9 Also include typing checks in lint:check d5682c228 Fix lint error. cca4659c4 Do outputs_hidden to collapsed conversion only at initial cell model construction. fbd8d33c1 Make cell model automatically transfer jupyter.outputs_hidden to collapsed metadata. 2afb78319 update search colors by theme, change style for unselected match 1fb5462d9 reflect new default styleSelectedText setting 3354b8adf turn on styleSelectedText by default, add style for selected search text 98ebe628d Merge pull request #6058 from Madhu94/uninstall-all-extensions fd614254d Merge pull request #6083 from AlbertHilb/PreventFocusLoss3 5b7220016 Elaborate on reasoning for using mousedown for toolbar button actions 420475486 restyle to use outline, selected cell color, and proper sizing c0e9eb946 Merge pull request #6125 from ian-r-rose/strict-promises 10d077165 Remove support for jupyter.outputs_hidden metadata a70313650 Update our nbformat typings to understand source_hidden and outputs_hidden. 4a6473e17 Merge pull request #6139 from minrk/referer 40da3e9d2 Merge branch 'master' of github.com:jupyter/jupyterlab into save-with-options 6ec8f2f91 Remove unused convenience functions for clearing/loading/saving notebook cell view metadata 76374d0c5 Make output hidden state solely controlled by the `collapsed` metadata. 20b02dc37 Fix typo in package.json: tsp -> tsc 850fe42f3 use target=_blank for download links cba7c8945 Update to Vega 5 (#6133) 01437e176 Add notebook tools tests 5be171595 Don't set execution count on markdown cells. f8d975854 Merge pull request #6049 from gnestor/issue-5971 ff72f895b Merge pull request #6051 from gnestor/issue-5973 e7953f316 Missed an async. 29288868b Disable the 'await-promise' rule for Comms. In the future we may want to rethink whether they can return `void | PromiseLike<void>`, but for now just allow that. 014d999a2 No floating promises in examples. 002ce5418 No floating promises in buildutils. ab102a692 No floating promises in tests. 05a6f96d7 Add --jp-input-active-box-shadow-color CSS variable 500e43bb6 Unset body color f63a32c42 Clean up ui-components styles 65dcb6e7c Clean up classnames of instances of ToolbarButton eb8f0a046 Add jp-Icon and jp-Icon-16 classnames to ToolbarButtons with icons 4a0234e36 Fix enable/disable button in extensionmanager 068515908 No floating promises in core packages. e04a3deb5 Enable strict promise rules. d5539206d Merge pull request #6123 from ian-r-rose/into-the-heart-of-the-services 5dfcb8a04 Move version pinning to the [test] group. 426adbdd7 Revert "Revert 98cee8c92587a8e037b5fac6cb6, which, while not necessarily a bug," c498c05f1 Try rolling back notebook and tornado. fd5c9ef07 Await a few promises in kernel tests. 34cd1cea7 Properly await shutting down all terminal sessions. a33bdcb67 Revert 98cee8c92587a8e037b5fac6cb6, which, while not necessarily a bug, was probably not helping. 8c93ed6b5 Properly await shutting down sessions. 7d3341722 Add an onActiveNotebookPanelMetadataChanged handler to notebook tools. aae14ef4b onCellMetadataChanged -> onActiveCellMetadataChanged to be more descriptive. 42c45e55b Add tests for new cell methods. 4f79ecde5 Fix test compilation errors. 7725e1d56 Fix a compilation error. cbc43d974 Fix printing typing abf36529e Use dev-build as alias e5a0abc50 Add an 'all' flag to uninstall all labextensions in the app-dir 7be32b420 Update faq.rst 13c63ae4b Simplify implementation 8ad8972a8 Remove base URL references 67dbe5d81 Start moving to new printing system 3a77854ca Add more logging when processing invalid JSON 9be3a439c fixup! Update react and react-dom to let extensions use React hooks 07fb2ed82 Remove overly abstracted definition aa8e5579b Start adding generic printing 1da3604a8 Reset iframe src when printing 6f6b9679d Fix linting 783842574 Rename printd function to printWidget e441c50f6 Allow notebook printing 1b01f6861 Add newline back c58e78cc0 Check if printable again when executing 00349dc01 Add documentation to printing module ecf0a10d2 Add printing for images, JSON and inspector a788ee7ed Move printint to apputils and add support docs ef8213ed3 Add printd 76397e429 add tabindex to searchbox, show drop shadow for keyboard navigation 906022992 Make NotebookTools use the tracker activeCell, activeCellChanged, etc. again. 917d61bc6 Use the `mousedown` event to trigger toolbar button actions. 2090823be Add back the notebook tracker activeCell and selection properties. 0fc7a2898 Tweak styling of advanced notebook tools. 0950df4cb Fix compile error with obsolete import 254e1c947 Added CSS selector descriptions 6cf727b22 Move celltools test file to notebooktools b01a6795b Update mentions of celltools to notebooktools in tests. 2d2b0d37e Remove unnecessary blueprint imports. 34721ee3f Move celltools.ts -> notebooktools.ts to reflect the broader purpose better. 60e578975 Small code cleanups 5e560b67d Delete unused cell tools. 1b56410ef Fix typo so we can cleanly merge into master. 89806074e Fix light theme caret down icon svg. 38334aa37 Fix collapse dropdown arrows in Chrome. 53907c431 Styling changes 1bb75a223 Delete `py -3` instructions in favor of `python3` 0edb9a28e Passing entire metadata instead of only kernel f27b639f1 Pass metadata["kerne"] from notebook to console 7f4fa706d Update language around SUSE, correct typos. 69322774c Update react and react-dom to let extensions use React hooks 84d71c852 Adding SUSE SLES 15 and openSUSE as supported platforms 153e63042 Use active cell instead of index 0f66b2860 Remove command from code runner interface 74c5398bc Use render 2d86f2312 Simplify notebook tools sidebar 8216f397a Change json editor to not do its own collapsing. 376239652 Collapse fixes 09e8f053c Change the order of the Notebook tools and Cell tools. 0c0bcec7b Move the Collapse widget to apputils. a73737bd2 Delete configuration for cell collapse, scroll, and editable metadata syncing. 9ba8d5c9d added notes, removed unused CSS b1074ecc3 Prevent running cell when no markdown cells are there ad086c638 Fix wording 7fe1921ca Cover some edge cases fe9195c3f Remove console statements 11823eac7 Getting things to work ef6f68917 Add collapsible sections to the notebook toolbar. 07b87584f switch from 'display: none' to `hide`/`show` 5fec03859 Fix integrity and compilation errors. b820fe7d3 Clean up old unused code. 99e5dd21f Clean up more logic preventing loops in setting synced values. 16b01c875 Add notebook settings for automatic syncing cell metadata. 5c74be377 Add TODO to allow setting automatic syncing attributes. cb1d0f45d Fix automatic syncing with metadata. 451cc8fb8 Add editable property syncing f7a3d786c Remove unused CSS class. 654be6708 linter complained, fixed it e6982d605 fixed var/setting names, changed isScrollbar -> themeScrollbars 89d244c9d delinted 8ff702a09 Move cell widget to model logic into the cell widget. d5907f1b5 small regression and cleanup 1e1b0d7b3 first stab at support for scrollbar styling on all browsers (except edge) 0e3f4472c wip f7fa0b1d7 add syncing for collapse state in the cell widget 32419dadb Add notebook-level syncing cell tools for scrolled and collapsed state. ccf736592 Merge branch 'master' into save-with-options 2734cfacf Add cell tools for initial collapse and scroll state. 53bdc87d8 Revamp cell tools, slim down the notebook instance tracker. 3532afa65 Make handler calling order in instance tracker consistent. 3d5c86e76 Merge remote-tracking branch 'upstream/master' into lazy-load-xterm-extension-promise 56ac4a695 more docs, error catching 4b79d867e try async loading from the extension side, refactor terminal interface, async all the things 9ce1fbc45 add fake widgets option for testing 1daf3a573 Automatically always save view state, using the context save signal. 512f00983 Simplify docmanager functions by using higher-order iterator functions rather than loop primitives. f821f123e Make menu extender “with Options” instead of “with Extras” 1200b008a Make save options work even when not remembering the options f543fde9e Capitalize save option dropdown options 50c6c49fe Make dialog title and menu entry consistent edb057265 Capitalize menu option. 89384deec Make save options not be inline form groups. 55d054388 Implement simple notebook save options setting system. 2112219e6 Rename the persist and save things to the more generic save with options. 4a203106c WIP save hook - probably to be deleted later. 5c1ac3d7a Make dev build arg an alias instead of flag git-subtree-dir: jupyterlab git-subtree-split: cf984351d71fe99506bcc15f9f048763f38d2012
|
Specifying only I had to set also Is this wanted? I'm asking this because @konpikwastaken wrote
I'm not happy about the workaround word. |
|
AFAICT this update to ts-loader (released as 6.0.2) should make setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes #939 (sorry, dyslexic branch name).
Note that to repro you'll need to make sure that the root level typescript version is set to 3.5.0-rc, otherwise the new set of tests happily pass.
Please do let me know if there's anything else to clean up.