run the tests with node11 as well #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very @zerdos PR 😊 |
|
Kinda weird that the large comparison test fails on node 11. I've no good explanation for that. I don't believe it's a meaningful failure. I think I'd like to transition the comparison test to be an execution test instead. It doesn't need to be a comparison test; and looking at the nature of the node 11 "failure" an execution test should pass consistently regardless of node version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the node 11 is an active release (https://github.com/nodejs/Release#release-schedule), so let's run the ts-loader tests on that version as well :)