-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): resolve src attribute on the script block on Vue files #130
Conversation
Thanks for the PR @ktsn! Looks initially good to me. @prograhammer @CKGrafico @wonderful-panda I believe you're Vue users and have worked on the Vue support in the plugin. Would you be able to look at this PR and let us know what you think? cc @yyx990803 |
Looks really nice! |
LGTM |
👍 |
Okay - I think we're good to merge! @ktsn can you comment on whether the |
Thanks for taking a look at this PR 🙏 @johnnyreilly The current vue-template-compiler does not include the types but it would be included and we will be able to consume it directly in the future since there is a PR already (maybe vue-template-compiler v2.6.0?). |
Awesome! Then let's go with this for now and if that PR gets merged we can switch to consuming from there later. Thanks for your work! |
Merged - this will be published once a new token has been generated for publishing. See #132 |
I'm not pretty sure, but seems this is the change that will somewhat cause tslint to complain if
|
We should not trim blank line because reported diagnostics will point to wrong location if we do that. I remember vue-template-compiler pads the blank lines with I will make a PR to fix the issue later. |
This PR fixes #111 and vuejs/vue-cli#1104. Also probably fixes #85.
I've replaced
vue-parser
withvue-template-compiler
which is Vue official package for parsing.vue
file. Becausevue-parser
looks not maintained and it would be better to use officially provided lib for consistency.I didn't include
vue-template-compiler
in dependencies because there is a known issue that mismatching with user-installedvue
version.The users should not feel inconvenience by this because
vue-loader
(official webpack loader for.vue
file) enforces the users to installvue-template-compiler
due to this issue. That means if the users want to usevue
option of this plugin, they already installvue-template-compiler
by themselves.