-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for running the local copy of babel for a given project #727
Conversation
@david-driscoll big fan of yours. Just added you as an owner. Do and support whatever feature you want in this project all the way up to releasing new versions 🌹 Let me know if you have any questions. |
@basarat big fan of yours too! 💯 I'm actually running into an strange issue here... when running with |
I've had stuff like that happen. Running atom as node can be weird: microsoft/TypeScript#2503 .
|
@nycdotnet, have any time to test it, I believe you worked on the original integration. |
I did. Ironically the very reason I did it was for the scope-per-iteration behavior of let in for loops which is now available in TS 1.7. I don't have time to test it until after my Pluralsight course is done, but maybe in a week or two. If it feels magical like "holy crap it worked" then it's probably fine. That was my acceptance criteria. BTW: loved your DNR episode. |
💯 . Because of that episode I sneak peaked the syntactic highlight code (I have a new non atom version for TypeScript) and will definitely be adding code lens (alm-tools/alm#41 not hard to do thanks to CodeMirror's inline widget API) 🌹 |
I've been using this lately without any large issues, so I'm going to drop it in, and see if something gets reported. |
Added support for running the local copy of babel for a given project
Thanks man! Nice work. I'm glad you were able to promise-ify it as well. As soon as my course is done, I'll be able to come up for air and check it out. |
This removes the dependency on
atom-typescript
's local copy of babel, and allows a given project to use whatever version they like (assuming the core.transform
api doesn't change anyway).Also adds support for loading configuration from
.babelrc