Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for running the local copy of babel for a given project #727

Merged
merged 1 commit into from
Nov 19, 2015

Conversation

david-driscoll
Copy link
Member

This removes the dependency on atom-typescript's local copy of babel, and allows a given project to use whatever version they like (assuming the core .transform api doesn't change anyway).

Also adds support for loading configuration from .babelrc

@basarat
Copy link
Member

basarat commented Nov 16, 2015

@david-driscoll big fan of yours. Just added you as an owner. Do and support whatever feature you want in this project all the way up to releasing new versions 🌹

Let me know if you have any questions.

@david-driscoll
Copy link
Member Author

@basarat big fan of yours too! 💯

I'm actually running into an strange issue here... when running with debugSync it works correctly, then when running as a process it fails... silently... right at babel.transform... now to figure out what's happening.

@basarat
Copy link
Member

basarat commented Nov 16, 2015

when running as a process it fails... silently.

I've had stuff like that happen. Running atom as node can be weird: microsoft/TypeScript#2503 .

console.error with a try/catch around it to see whats going on.

@david-driscoll
Copy link
Member Author

@nycdotnet, have any time to test it, I believe you worked on the original integration.

@nycdotnet
Copy link
Contributor

I did. Ironically the very reason I did it was for the scope-per-iteration behavior of let in for loops which is now available in TS 1.7. I don't have time to test it until after my Pluralsight course is done, but maybe in a week or two. If it feels magical like "holy crap it worked" then it's probably fine. That was my acceptance criteria.

BTW: loved your DNR episode.

@basarat
Copy link
Member

basarat commented Nov 18, 2015

BTW: loved your DNR episode.

💯 . Because of that episode I sneak peaked the syntactic highlight code (I have a new non atom version for TypeScript) and will definitely be adding code lens (alm-tools/alm#41 not hard to do thanks to CodeMirror's inline widget API) 🌹

@david-driscoll
Copy link
Member Author

I've been using this lately without any large issues, so I'm going to drop it in, and see if something gets reported.

david-driscoll added a commit that referenced this pull request Nov 19, 2015
Added support for running the local copy of babel for a given project
@david-driscoll david-driscoll merged commit 205cba0 into TypeStrong:master Nov 19, 2015
@david-driscoll david-driscoll deleted the local-babel branch November 19, 2015 21:35
@nycdotnet
Copy link
Contributor

Thanks man!

Nice work. I'm glad you were able to promise-ify it as well.

As soon as my course is done, I'll be able to come up for air and check it out.

@basarat
Copy link
Member

basarat commented Nov 24, 2015

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants