Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rewriteTsconfig flag in tsconfig.json #715

Merged
merged 3 commits into from
Nov 16, 2015

Conversation

szunami
Copy link

@szunami szunami commented Nov 11, 2015

The rewriteTsconfig flag enables users to prevent Atom-Typescript
from rewriting their tsconfig.json. The flag defaults to true,
so users who upgrade won't observe any different behavior.

The FAQ and tsconfig docs have been modified to reflect
rewriteTsconfig.

This resolves #703.

The rewriteTsconfig flag enables users to prevent Atom-Typescript
from rewriting their tsconfig.json. The flag defaults to true,
so users who upgrade won't observe any different behavior.

The FAQ and tsconfig docs have been modified to reflect
rewriteTsconfig.

This resolves TypeStrong#703.
@basarat
Copy link
Member

basarat commented Nov 11, 2015

@sszuflita Thanks! Can you move it under the atom key. I know this is the first time we move stuff in there, but this is an option likely to be used by other things like grunt too.

@szunami
Copy link
Author

szunami commented Nov 12, 2015

What do you mean by this? I am interpreting this to mean:

{
"compilerOptions": {...},
"filesGlob": [...],
"files": [...],
"exclude":[...],
"atom": {
rewriteTsconfig: false;
}

}

If we store this option in an object labelled atom, how does this help grunt access it? To me it seems like storing it in an object labelled atom would would suggest this option is relevant only to atom.

@basarat
Copy link
Member

basarat commented Nov 12, 2015

Yes I want it under atom. So that grunt can still rewrite if users want grunt to rewrite. Grunt would look at "grunt//rewrite..." 🌹

Sam Szuflita added 2 commits November 12, 2015 16:06
The rewriteTsconfig flag enables users to prevent Atom-Typescript
from rewriting their tsconfig.json. The flag defaults to true,
so users who upgrade won't observe any different behavior.

The FAQ and tsconfig docs have been modified to reflect
rewriteTsconfig.

This resolves TypeStrong#703.
@basarat
Copy link
Member

basarat commented Nov 16, 2015

Awesome. Thanks a million @sszuflita !

TIP: github doesn't notify if you only push more commits. Please leave a message in PRs that have been reworked 🌹

basarat added a commit that referenced this pull request Nov 16, 2015
Support rewriteTsconfig flag in tsconfig.json
@basarat basarat merged commit 3faba06 into TypeStrong:master Nov 16, 2015
@basarat
Copy link
Member

basarat commented Nov 16, 2015

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to prevent rewriting tsconfig.json file
2 participants