TS emit failed with latest release

[tomitrescak]

The build works as expected, but when compilation on save is emited following error is triggered:

[basarat]

The build works as expected, but when compilation on save is emited following error is triggered:

Sorry @tomitrescak. I tried a quick test and it works fine.

Can you share your tsconfig.json ... and are you using extenalTranspiler? (I'm personally not and don't even have it setup) 🌹

[basarat]

Got it. Happens if the file is a .d.ts file ... aka doesn't have a valid js status

[basarat]

Released: https://github.com/TypeStrong/atom-typescript/releases/tag/v7.14.0 have a nice weekend 🌹

[tomitrescak]

I admire your speeeeeeeeeeed 🎱 ;)

[laurelnaiad]

I suspect it's possible that the failures with d.ts files might be similar to the issue I'm chasing in #755. @tomitrescak (and @basarat ) when you were experiencing (and reproducing) this bug, were you compiling into your source directory? Or targeting a build directory distinct from your source directory? #755 popped up for me when I was looking at other babel-related code, as well. I will respond to @basarat's request for followup over in that thread now.

By the way, I totally get why reverting the babel thing makes sense for now. Those of us using babel can still use that commit until it's better sorted out. I think there are a few other issues with the babel integration that might as well all get packaged up together properly, rather than trying to piecemeal them as hotfixes to the babel support.

[tomitrescak]

[EDIT] - Nevermind what is written below .. I had downgraded atom-typescript to previous version, therefore I had no errors. I will keep on investigating.

Hi, 7.14.1 is still failing Emit ;( Last one that works is 7.12.0 ;(
I am not emiting files as per my tsconfig ... but I get the TS Emit failed message :/

  "compileOnSave": true,
  "compilerOptions": {
    "target": "es6",
    "declaration": false,
    "noImplicitAny": true,
    "removeComments": false,
    "noLib": false,
    "preserveConstEnums": true,
    "noEmitHelpers": true,
    "noEmit": true,
    "suppressImplicitAnyIndexErrors": true,
    "jsx": "preserve",
    "experimentalDecorators": true,
    "experimentalAsyncFunctions": true,
    "sourceMap": true
  },
  "awesomeTypescriptLoaderOptions": {
    "doTypeCheck": true,
    "useBabel": false,
    "emitRequireType": true,
    "forkChecker": true
  },
  "filesGlob": [
    "modules/**/*.ts",
    "modules/**/*.tsx"
  ],
  "files": [
...
  ],
  "exclude": [
    "node_modules"
  ],
  "atom": {
    "rewriteTsconfig": true
  }
}

[basarat]

Hi, 7.14.1 is still failing Emit ;(

@tomitrescak I believe the stack trace would now be different. Can you share that please 🌹

[tomitrescak]

Bad news ;( Stacktrace is empty .. no error in console. Only the TS failed to emit error.

[basarat]

ad news ;( Stacktrace is empty .. no error in console. Only the TS failed to emit error.

@tomitrescak I don't have a repro :-/ Also you seem to be the only one suffering from this at the moment. I am open to suggestions 🌹

[tomitrescak]

@basarat GOT IT!

The culprit is the "noEmit": true

With compilation set to some outDir no problems appear.
When I turn on the noEmit rule in any of my projects I receive the TS Emit Failed.

I can reproduce this issue in ALL my projects, please test it if you have time.

[basarat]

The culprit is the "noEmit": true

Wouldn't noEmit explicitly disable any emit? So we shouldn't show the message but the rest is fine? Am I mistaken? 🌹

[tomitrescak]

Yes, you are right. I'm not sure if on-the-fly compilation does the same as compilation on save, but the Emit Failed message should not be shown as it is a bit misleading since compilation is performed just fine.

[basarat]

@tomitrescak I've created a clearer issue report : #780 🌹

[tomitrescak]

@basarat I still get TS Emit failed when emit is set to false ;(

[basarat]

@tomitrescak the issue still exits : #780

I have difficulty wrapping my head around why one would even need noEmit : true? Surely something must be doing the emit and that thing is effectively ignoring the noEmit option. What is that thing? 🌹

[laurelnaiad]

My entire build process uses gulp-typescript and gulp-babel... including building the build itself -- so that no particular editor is needed, and so that we can control the streams, etc. etc. It also transpiles itself.

I always run with noEmit: true now.

(gulp-typescript happily, and correctly-for-its-use-case ignores the noEmit flag)

[basarat]

Cool so gulp-typescript ignores noEmit (https://www.npmjs.com/package/gulp-typescript#options). If all you want is just atom to ignore emit perhaps use compileOnSave: false as a workaround till the issue is fixed 🌹

[laurelnaiad]

Right -- difference being that the compile/buildOnSave settings prevent editor from assisting you in typechecking in-window.

I don't actually have an issue with noEmit anymore on my branch, so somewhere in there I think there's a fix (though maybe not an ideal one). I still need to deal with making that into a PR or PRs.

So, I don't need a workaround right now -- I was just chiming in with a reasoning behind wanting to run atom-typescript with noEmit turned on.

[tomitrescak]

@basarat I am running Webpack with ts-loader which is responsible for loading typescript and creating sourcemaps. Thereofre I do not need emission. I need compile on save to have the possibility of typechecks and more.

[basarat]

I need compile on save to have the possibility of typechecks and more.

Typechecks are performed irrespective of compileOnSave (code

atom-typescript/lib/main/atom/onSaveHandler.ts

Lines 31 to 56 in cdc8d98

	// Compile on save
	parent.getProjectFileDetails({ filePath: event.filePath }).then(fileDetails => {
	if (fileDetails.project.compileOnSave
	&& !fileDetails.project.compilerOptions.out
	&& !fileDetails.project.buildOnSave) {
	textUpdated.then(() => parent.emitFile({ filePath: event.filePath }))
	.then((res) => {
	let status = getFileStatus(event.filePath);
	status.modified = false;
	// If there was a compilation error, the file differs from the one on the disk
	status.emitDiffers = res.emitError;
	panelView.updateFileStatus(event.filePath);
	errorView.showEmittedMessage(res);
	});
	}
	if (fileDetails.project.buildOnSave) {
	// Trigger a build ;)
	atom.commands.dispatch(
	atom.views.getView(event.editor),
	'typescript:build');
	}
	});

). Correct me if I am wrong 🌹

[slavik57]

I don't know if it is relevant, but I got the same error,
I figured out why I got it, the problem for me was that the d.ts files of the project were included in the tsconfig.json/files section
so I added them to the tsconfig.json/exclude section and it worked out for me:
"exclude": [
"src/*/.d.ts",
"index.d.ts",
...
]

Hope it helps

[n9]

In my case, I have resolved TS emit failed message by removing "noEmitOnError": true from tsconfig.json:

{
  "compileOnSave": true,
  "compilerOptions": {
    "noImplicitAny": false,
    "noEmitOnError": true,
    "removeComments": false,
    "sourceMap": true,
    "target": "es5",
    "module": "system",
    "jsx": "react",
    "experimentalDecorators": true
  },
  "exclude": [
    "typings",
    "node_modules",
    "jspm_packages",
    "wwwroot"
  ]
}

The tsconfig.json above is taken from this guide. It works ok in VS2015 but not in Atom.

But, I am not sure whether this is related to this issue.

[sharpmachine]

Any progress on this bug? It's hella annoying.

[ghost]

bug still there so please fix

[tskweres]

still there, any ideas whatsup?

[xiongemi]

I got the same issue, too. Using Atom 1.10.2.

[josemera]

same here, when setting "noEmitOnError": true, I get the 'TS Emit Failed' message when saving even if there are no actual errors. I can compile the file on the command line with tsc and everything works fine, but not from Atom.

[sharpmachine]

I solved this issue by switching from Atom to VS Code. Atom was sweet, but VS Code is sweeter.