fix tippy -> floatingui #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -32,6 +33,14 @@ export const ImageToolbarPositioner = < | |||
|
|
|||
| const referencePos = useRef<DOMRect>(); | |||
|
|
|||
| const { refs, update, context, floatingStyles } = useFloating({ | |||
| open: show, | |||
| placement: "left", | |||
| }, | ||
| ], | ||
| }; | ||
| // TODO: anything from below needed? |
There was a problem hiding this comment.
This is just to ensure the side menu doesn't change position if it overflows. In Floating UI I think the way to do this is to just omit flip() from the middleware.
| }, | ||
| [referencePos.current] // eslint-disable-line | ||
| ); | ||
| // const { ref, updateMaxHeight } = usePreventMenuOverflow(); // TODO, needed? |
There was a problem hiding this comment.
This is indeed still needed - it's basically a fallback for handling overflow. Normally, if there's no space to render the menu in the default "bottom" position, it will get flipped to the top. But if the viewport itself is too small to see the whole menu, this hook constrains the height of the menu to fit in the viewport.
# Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue of #306
(currently branched of playground, might not be ideal)